Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings for s6603 #2252

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

sukreshmanda
Copy link
Contributor

Pull Request

The issue or feature being addressed

#1290

Details on the issue fix or feature implementation

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@sukreshmanda
Copy link
Contributor Author

@dotnet-policy-service agree

@martincostello
Copy link
Member

@dotnet-policy-service agree

You should only need to agree on your first PR, not each one 😃

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.33%. Comparing base (2ffa02e) to head (4f91eac).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2252   +/-   ##
=======================================
  Coverage   85.33%   85.33%           
=======================================
  Files         313      313           
  Lines        7444     7444           
  Branches     1122     1122           
=======================================
  Hits         6352     6352           
  Misses        746      746           
  Partials      346      346           
Flag Coverage Δ
linux 85.33% <ø> (ø)
macos 77.30% <ø> (-8.03%) ⬇️
windows 85.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 411cfdc into App-vNext:main Jul 29, 2024
18 checks passed
@sukreshmanda sukreshmanda deleted the warnings-s6603 branch July 29, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants