feat: adds compiler_cache_folder config var #1897
Conversation
mikeshultz
added
category: feature
|
Related: ApeWorX/ape-solidity#62 |
There was a problem hiding this comment.
I tried using ManagerAccessMixin myself just to make sure and yeah you can't do it because it's loading still.
I can't really think of another way to do it either and this way if this problem again, we at least have a solution for it (rather than 1-off fix each time).
LGTM
|
|
I converted to a Draft just to make it less likely to merge until it's ready |
…y, tighten up cache_folder relative path handling, and prevent escape of project root
src/ape_compile/__init__.py
Outdated
| if self._config_manager.contracts_folder not in self.cache_folder.parents: | ||
| return self._config_manager.PROJECT_FOLDER | ||
|
|
||
| # Otherwise, we're defaulting to contracts folder for backwards compatibility. Chaning this |
There was a problem hiding this comment.
question: Thoughts on for 0.8 using the project path as the base regardless, as a breaking change?
There was a problem hiding this comment.
I have no issues with making this change. We may want to document the old way somehow so users can reconstruct their project to match the old ways (or just instruct them to use an old version of ape and its deps, if possible). It's hard to get a sense how important repeatable builds are.
I also think it's worth discussing the idea in #1912. The functionality in it could be used for some kinds of build stages to assemble the compilation directory structure. Then it wouldn't matter where users put things. And we wouldn't need to really put a dependency cache anywhere semi-permanently. It's possible we could introduce this in a way to not be breaking.
Co-authored-by: antazoey <[email protected]>
Co-authored-by: antazoey <[email protected]>
What I did
Adds the
cache_folderconfig var for ape_compile. Compiler plugins will leverage this for various temporary build-storage (mostly dependency sources).Ref: #1335
Checklist