-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support configured dependency cache directory #133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Vyper need a similar one?
ape-vyper doesn't leverage the dependency cache folder and the |
This should be g2g after next Ape release ETA: this PR will need to be updated with that version update as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good pending @antazoey approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ship it asap!
What I did
Adds support for new
cache_folder
config var which defines where to place non-project dependencies.Example config:
Depends on: ApeWorX/ape#1897
How I did it
Replaces hard references to
.cache
to configuration. Relies on base_dir for relative paths.How to verify it
Run against branch from above linked PR.
Checklist