Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle implicit relative imports #128

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Jul 23, 2024

What I did

fixes: #125

implicit relative imports from the same directory as the source were not working

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey mentioned this pull request Jul 23, 2024
4 tasks
@antazoey antazoey changed the title fix: implicit relative imports fix: handle implicit relative imports Jul 23, 2024
@antazoey antazoey marked this pull request as ready for review July 23, 2024 15:32
fubuloubu
fubuloubu previously approved these changes Jul 23, 2024
@antazoey antazoey force-pushed the fix/weird-import-style branch from be7e7e3 to c7dea80 Compare July 23, 2024 16:02
@dtdang dtdang mentioned this pull request Jul 23, 2024
4 tasks
@antazoey antazoey requested a review from dtdang July 23, 2024 16:29
@antazoey
Copy link
Member Author

@bitwise-constructs

ape_vyper/compiler.py Outdated Show resolved Hide resolved
Copy link
Contributor

@bitwise-constructs bitwise-constructs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@antazoey antazoey merged commit 6d05c26 into ApeWorX:main Jul 23, 2024
11 checks passed
@antazoey antazoey deleted the fix/weird-import-style branch July 23, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFound:interfaces.IERC20Permit - Ape, Vyper & Snekmate
3 participants