Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: interfaces import #126

Closed
wants to merge 1 commit into from
Closed

Conversation

dtdang
Copy link
Contributor

@dtdang dtdang commented Jul 19, 2024

What I did

Fixes local importing of interfaces directory not being recognized as a local directory.

fixes: #125

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@dtdang dtdang requested a review from fubuloubu July 19, 2024 22:30
@dtdang
Copy link
Contributor Author

dtdang commented Jul 19, 2024

The issue was that because snekmate used local imports with import interfaces.IERC20Permit as IERC20Permit, we did not consider interfaces as a local dependency but was looking for a package under the name interfaces. This is a bit of a hack solution unless we can convince snekmate to import using import .interfaces.IERC20Permit as IERC20Permit or if there is a better solution but this one solves the issue for now.

@tloriato
Copy link

It works! Thank you, @dtdang !

@dtdang dtdang closed this Jul 23, 2024
@dtdang
Copy link
Contributor Author

dtdang commented Jul 23, 2024

A better fix for this was done with #128.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFound:interfaces.IERC20Permit - Ape, Vyper & Snekmate
2 participants