Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] Use other_branch_latest_time for liveness #627

Merged
merged 5 commits into from
Aug 27, 2024
Merged

[1.0] Use other_branch_latest_time for liveness #627

merged 5 commits into from
Aug 27, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Aug 23, 2024

Use other_branch_latest_time block timestamp instead of a boolean votes_forked_since_latest_strong_vote for tracking votes on other fork branches. See #621 for complete details.

Fixes currently failing test on #619.

Resolves #621 (Tests coming in separate PR)

@heifner heifner requested review from greg7mdp and arhag August 23, 2024 21:43
@heifner heifner added the OCI Work exclusive to OCI team label Aug 23, 2024
@heifner heifner linked an issue Aug 23, 2024 that may be closed by this pull request
Update fsi and decide_vote to solve weak masking issue without regression in liveness #621
Closed
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: INTERNALS
summary: Update finalizer logic to resolve weak vote, masking issues.
Note:end

@greg7mdp greg7mdp mentioned this pull request Aug 26, 2024
Merged
@heifner heifner requested a review from linh2931 August 27, 2024 03:02
Base automatically changed from GH-617-fsi-serialization to release/1.0 August 27, 2024 03:16
@heifner heifner merged commit 02727a4 into release/1.0 Aug 27, 2024
36 checks passed
@heifner heifner deleted the GH-621-liveness branch August 27, 2024 12:08
@heifner heifner mentioned this pull request Aug 27, 2024
Merged
@greg7mdp greg7mdp mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhag arhag arhag approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

@linh2931 linh2931 Awaiting requested review from linh2931

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update fsi and decide_vote to solve weak masking issue without regression in liveness
4 participants
@heifner @ericpassmore @greg7mdp @arhag