Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0 -> main] Add testcase validating the new fsi design from issue #660

Merged
merged 28 commits into from
Aug 28, 2024
Merged

[1.0 -> main] Add testcase validating the new fsi design from issue #660

merged 28 commits into from
Aug 28, 2024

Conversation

greg7mdp
Copy link
Contributor

@greg7mdp greg7mdp commented Aug 28, 2024 •
edited
Loading

Last PR to resolve #621.

Adds a testcase that demonstrates issue #621. Testcase fails prior to PR #650.

@greg7mdp
Start on gh_534_liveness_issue testcase
7b0f1e7
@greg7mdp
Merge branch 'gh_544' of github.com:AntelopeIO/spring into gh_621
994a9a0
@greg7mdp
Some progress on gh_534_liveness_issue testcase
3a9d896
@greg7mdp
Merge branch 'gh_544' of github.com:AntelopeIO/spring into gh_621
fe23716
@greg7mdp
Minor cleanup
baad9f2
@greg7mdp
Implement vote delay for savanna_cluster
040d4b2
@greg7mdp
Finish gh_534_liveness_issue testcase
0391637
@greg7mdp
Validate testcase gh_534_liveness_issue with fsi changes.
74d1668
@greg7mdp
Comment out new testcase as it fails with current fsi implementation
bf5f7cd
@greg7mdp
Add big block comment copied from issue #621.
1d19e44
@greg7mdp
Merge branch 'release/1.0' of github.com:AntelopeIO/spring into gh_621
5cbed82
@greg7mdp
Address PR comment.
b8d832c
@greg7mdp
Merge branch 'release/1.0' of github.com:AntelopeIO/spring into gh_621
27cbf08
@greg7mdp
Address PR comments, incl. not skipping slots for b5 to b8.
8f383b6
@greg7mdp
Make the checks a little cleaner by using strong_qc/weak_qc and sam…
3a5f697 
…e for `vote`
@greg7mdp
Forgot this file!
9153e40
@greg7mdp
Merge branch 'release/1.0' of github.com:AntelopeIO/spring into gh_621
8a0163c
@greg7mdp
Remove #ifdef, align comments.
511c2a1
@greg7mdp
Merge branch 'release/1.0' of github.com:AntelopeIO/spring into gh_621
d873f75
@greg7mdp
Add fsi checks.
d3bb815
@greg7mdp
Make check_fsi checks a bit clearer.
4d5f1cb
@greg7mdp
Make get_node_finalizers private and fix test.
81df896
@greg7mdp
Add Boost::crc as a controller dependency.
7db6083
@greg7mdp
Move check_fsi() to savanna_cluster so it can be re-used.
9758307
@greg7mdp
Add Boost::crc to EosioTester.cmake.in and `EosioTesterBuild.cmak…
cd44dc7 
…e.in`
@greg7mdp
Merge pull request #636 from AntelopeIO/gh_621
b4fbc56 
[1.0] Add testcase validating the new fsi design from issue #621.
@greg7mdp
Merge remote-tracking branch 'origin/release/1.0' into gh_621_main
0e7392d
@greg7mdp
Merge branch 'main' of github.com:AntelopeIO/spring into gh_621_main
23d80b0
@greg7mdp greg7mdp requested a review from arhag August 28, 2024 03:22
heifner
heifner approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@heifner heifner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the PR description, it is no longer commented out. Also update the merged 1.0 PR description.

@greg7mdp greg7mdp merged commit da8c741 into main Aug 28, 2024
36 checks passed
@greg7mdp greg7mdp deleted the gh_621_main branch August 28, 2024 13:03
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: TEST
summary: Test to validate new, generation 1, finalizer safety information.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@heifner heifner heifner approved these changes

@arhag arhag Awaiting requested review from arhag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update fsi and decide_vote to solve weak masking issue without regression in liveness
4 participants
@greg7mdp @ericpassmore @heifner @linh2931