Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Instant finality updates #43

Merged
merged 106 commits into from
Apr 29, 2024
Merged

IF: Instant finality updates #43

merged 106 commits into from
Apr 29, 2024

Commits on Dec 11, 2023

  1. add setfinalizer to eosio.bios

    @linh2931
    linh2931 committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    37e4b25 View commit details
    Browse the repository at this point in the history

  2. add tests for eosio.bios setfinalizer action

    @linh2931
    linh2931 committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    6eac8c2 View commit details
    Browse the repository at this point in the history

  3. add more comments to eosio.bios setfinalizer tests

    @linh2931
    linh2931 committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    7181593 View commit details
    Browse the repository at this point in the history

  4. update Leap and CDT versions for CICD

    @linh2931
    linh2931 committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    0d5cc0d View commit details
    Browse the repository at this point in the history

  5. use std::move for argument passing

    @linh2931
    linh2931 committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    f91b47f View commit details
    Browse the repository at this point in the history

  6. correct a typo of privileged

    @linh2931
    linh2931 committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    4e31832 View commit details
    Browse the repository at this point in the history

  7. update CDT asset-artifact-download-action from v2 to v3

    @linh2931
    linh2931 committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    37c4dc3 View commit details
    Browse the repository at this point in the history

  8. add apt-get update && apt-get upgrade -y before apt install

    @linh2931
    linh2931 committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    da83307 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. change leap-dev asset-artifact-download-action to v3

    @linh2931
    linh2931 committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    d9dceab View commit details
    Browse the repository at this point in the history

  2. remove token usage

    @linh2931
    linh2931 committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    5b3c58e View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. correct comments about setfinalizer and add max_finalizers and max_fi… 

    …nalizer_description_size definition
    @linh2931
    linh2931 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    d7f7616 View commit details
    Browse the repository at this point in the history

  2. add checks for duplicate keys, too small threshold, weight sum overfl… 

    …ow, max_finalizers, and max_finalizer_description_size
    @linh2931
    linh2931 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    312f46a View commit details
    Browse the repository at this point in the history

  3. add additional tests for setfinalizer input validation

    @linh2931
    linh2931 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    d5bf241 View commit details
    Browse the repository at this point in the history

  4. simplify building long description in tests and add a test for descri… 

    …ption length equal to max allowed size
    @linh2931
    linh2931 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    8676a92 View commit details
    Browse the repository at this point in the history

  5. use affine raw format for key uniqueness check

    @linh2931
    linh2931 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    ac597ea View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. move g1_hash and g1_equal inside function body and next to their use,… 

    … use std::hash<const char*> for hashing, use size() instead of 96 * sizeof(char)
    @linh2931
    linh2931 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    89672ac View commit details
    Browse the repository at this point in the history

  2. Merge pull request #33 from AntelopeIO/setfinalizer 

    IF: Add setfinalizer action to eosio.bios
    @linh2931
    linh2931 authored Dec 14, 2023
    Configuration menu
    Copy the full SHA
    57218e4 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. GH-34 Update set_finalizer errors

    @heifner
    heifner committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    afe749a View commit details
    Browse the repository at this point in the history

  2. Merge pull request #35 from AntelopeIO/GH-34-set-finalizer-errors 

    Update set_finalizer errors
    @heifner
    heifner authored Dec 19, 2023
    Configuration menu
    Copy the full SHA
    247b5c4 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. GH-37 Update to use controller active_producers(0 instead of accessin… 

    …g head_block_state.
    @heifner
    heifner committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    a3ee2ed View commit details
    Browse the repository at this point in the history

  2. GH-37 Use cdt finalizer_authority

    @heifner
    heifner committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    5e95bc2 View commit details
    Browse the repository at this point in the history

  3. GH-37 Update to ubuntu-22.04

    @heifner
    heifner committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    e28a8ee View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Merge remote-tracking branch 'origin/main' into merge-main-01-08-2023

    @heifner
    heifner committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    4cab488 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'merge-main-01-08-2023' into GH-37-update-for-if

    @heifner
    heifner committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    6a5be27 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. GH-37 New block extension for instant finality

    @heifner
    heifner committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    25d6b28 View commit details
    Browse the repository at this point in the history

  2. Empty commit

    @heifner
    heifner committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    cae6ac4 View commit details
    Browse the repository at this point in the history

  3. GH-37 Rename variable to make clearer

    @heifner
    heifner committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    889d3e9 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Merge pull request #38 from AntelopeIO/GH-37-update-for-if 

    IF: Update for latest IF
    @heifner
    heifner authored Jan 10, 2024
    Configuration menu
    Copy the full SHA
    0137e60 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #40 from AntelopeIO/merge-main-01-08-2023 

    IF: Merge main 01-08-2023
    @heifner
    heifner authored Jan 10, 2024
    Configuration menu
    Copy the full SHA
    b1a152d View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. GH-41 Add verification that finalizer weight_sum is >= threshold

    @heifner
    heifner committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    ea0835b View commit details
    Browse the repository at this point in the history

  2. GH-41 Missed a couple of updates

    @heifner
    heifner committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    a32800d View commit details
    Browse the repository at this point in the history

  3. GH-41 Missed one

    @heifner
    heifner committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    401c8b1 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #42 from AntelopeIO/GH-41-enforce-fin-weight 

    IF: Enforce finalizer sum of weights >= threshold
    @heifner
    heifner authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    ad67480 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. signals are now accessors not members

    @heifner
    heifner committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    2977500 View commit details
    Browse the repository at this point in the history

  2. Temporarily change target

    @heifner
    heifner committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    635ff86 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #50 from AntelopeIO/if-signals 

    IF: Controller signals are now accessors not members
    @heifner
    heifner authored Feb 6, 2024
    Configuration menu
    Copy the full SHA
    ea58e91 View commit details
    Browse the repository at this point in the history

  4. Switch back to instant-finality now that it is updated

    @heifner
    heifner committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    3816c69 View commit details
    Browse the repository at this point in the history

  5. Should be hotstuff_integration

    @heifner
    heifner committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    2d30776 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #51 from AntelopeIO/if-defaults 

    IF: Use leap hotstuff_integration branch
    @heifner
    heifner authored Feb 6, 2024
    Configuration menu
    Copy the full SHA
    9dad4d8 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. update bios finality tests using new keys and signatures in base64 ur… 

    …l format
    @linh2931
    linh2931 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    63bd278 View commit details
    Browse the repository at this point in the history

  2. temporarily change leap-dev target to pubkey_base64url for build

    @linh2931
    linh2931 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    5ff038d View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Merge pull request #56 from AntelopeIO/new_base64_encoding 

    IF: Update BIOS finality tests to use base64url encoded BLS keys and signatures
    @linh2931
    linh2931 authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    1049b2c View commit details
    Browse the repository at this point in the history

  2. change leap-dev target back to hotstuff_integration

    @linh2931
    linh2931 committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    e09fd4e View commit details
    Browse the repository at this point in the history

  3. Merge pull request #57 from AntelopeIO/leap_dev_target 

    IF: change leap-dev target back to hotstuff_integration
    @linh2931
    linh2931 authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    469e1b3 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Add core contract actions to support Savanna draft version

    @linh2931
    linh2931 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    5d7b0f2 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. First working version of core contact actions for Savanna

    @linh2931
    linh2931 committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    96d4877 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. rename producer to finalizer in all finalizer key actions

    @linh2931
    linh2931 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    c929439 View commit details
    Browse the repository at this point in the history

  2. Check if finalizer has registered any keys earlier

    @linh2931
    linh2931 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    bdd7f8e View commit details
    Browse the repository at this point in the history

  3. Remove unused top_producer_names and change a check() to an assert()

    @linh2931
    linh2931 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    c4dbf90 View commit details
    Browse the repository at this point in the history

  4. Change er_authorities parameter in set_finalizers() to move semantics

    @linh2931
    linh2931 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    097cd79 View commit details
    Browse the repository at this point in the history

  5. Use eosio::current_time_point() for _gstate.last_producer_schedule_up… 

    …date in switchtosvnn
    @linh2931
    linh2931 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    a70ea46 View commit details
    Browse the repository at this point in the history

  6. Use producers.size() instead of top_producers.size() as that is what … 

    …is actually used
    @linh2931
    linh2931 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    5908fb9 View commit details
    Browse the repository at this point in the history

  7. Update action descriptions

    @linh2931
    linh2931 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    47535c2 View commit details
    Browse the repository at this point in the history

  8. Use sha256 of base64url as the hash of the key, cache the hash to avo… 

    …id re-hashing
    @linh2931
    linh2931 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    21e8dcb View commit details
    Browse the repository at this point in the history

  9. Rename finalizer to finalizer_name in actions and tables so it is mor… 

    …e clear
    @linh2931
    linh2931 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    cf14212 View commit details
    Browse the repository at this point in the history

  10. Use a table to store last finalizer key IDs

    @linh2931
    linh2931 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    95cf0f9 View commit details
    Browse the repository at this point in the history

  11. check if the finalizer_key starts with PUB_BLS in actfinkey action

    @linh2931
    linh2931 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    41e3a30 View commit details
    Browse the repository at this point in the history

  12. remove key id from last_finkey_ids table if the removed key is the la… 

    …st registered one
    @linh2931
    linh2931 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    689a4ea View commit details
    Browse the repository at this point in the history

  13. Simplify tests

    @linh2931
    linh2931 committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    95afd18 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Add activating finalizer key tests

    @linh2931
    linh2931 committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    40d2daf View commit details
    Browse the repository at this point in the history

  2. Partial delete finalizer key tests

    @linh2931
    linh2931 committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    8ee26c4 View commit details
    Browse the repository at this point in the history

  3. more delete finalizer key tests

    @linh2931
    linh2931 committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    aede338 View commit details
    Browse the repository at this point in the history

  4. more efficiently updating last finalizer keys table

    @linh2931
    linh2931 committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    c676d31 View commit details
    Browse the repository at this point in the history

  5. Add the first switch-to-Savanna action test

    @linh2931
    linh2931 committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    3b9c2c4 View commit details
    Browse the repository at this point in the history

  6. Verify nodeos indeed switches to Savanna after switchtosvnn action is… 

    … pushed
    @linh2931
    linh2931 committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    0f5d3f7 View commit details
    Browse the repository at this point in the history

  7. use std::move when setting finalizer_authorities

    @linh2931
    linh2931 committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    b734453 View commit details
    Browse the repository at this point in the history

  8. add missing finalizer_name in action descriptions

    @linh2931
    linh2931 committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    6bccc06 View commit details
    Browse the repository at this point in the history

  9. Add a test for not enough finalizer keys registered for switching to … 

    …Savanna
    @linh2931
    linh2931 committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    00f5265 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Add tests for update_elected_producers in both finalizer key changes … 

    …and no finalizer key changes
    @linh2931
    linh2931 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    59184cc View commit details
    Browse the repository at this point in the history

  2. Fix primary key modified in replace_key_in_finalizer_policy()

    @linh2931
    linh2931 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    33e54f1 View commit details
    Browse the repository at this point in the history

  3. Add a test of deleting an active producer's finalizer key and another… 

    … producing taking over
    @linh2931
    linh2931 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    6a21d55 View commit details
    Browse the repository at this point in the history

  4. Simplify tests using a new get_last_finkey_ids()

    @linh2931
    linh2931 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    8153e6e View commit details
    Browse the repository at this point in the history

  5. minor editorial improvements

    @linh2931
    linh2931 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    f2d650c View commit details
    Browse the repository at this point in the history

  6. Improve action descriptions

    @linh2931
    linh2931 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    c39bf62 View commit details
    Browse the repository at this point in the history

  7. Rename active_key_id to active_finalizer_key_id, active_key to active… 

    …_finalizer_key_binary, and num_registered_keys to finalizer_key_count in finalizers table
    @linh2931
    linh2931 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    d5510f1 View commit details
    Browse the repository at this point in the history

  8. Move static keys and signatures out of finalizer_key_tester

    @linh2931
    linh2931 committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    5584a60 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2024

  1. Rename last_finkey_ids with last_fin_keys; add comments to fields of … 

    …new tables
    @linh2931
    linh2931 committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    c0d4a8d View commit details
    Browse the repository at this point in the history

  2. refactor replace_key_in_finalizer_policy() into generate_finalizer_po… 

    …licy_and_set_finalizers()
    @linh2931
    linh2931 committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    3ea54b1 View commit details
    Browse the repository at this point in the history

  3. Add authority check tests

    @linh2931
    linh2931 committed Apr 6, 2024
    Configuration menu
    Copy the full SHA
    6bf5dc5 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2024

  1. Cache finalizer key binary form in finalizers table; improve descript… 

    …ion of actions; various minor cleanups.
    @linh2931
    linh2931 committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    c9b156d View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Simplilfy the update_elected_producers test and small clean ups

    @linh2931
    linh2931 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    a2b44f4 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary set_proposed_producers related code in switosvnn()… 

    … action
    @linh2931
    linh2931 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    d5f68ad View commit details
    Browse the repository at this point in the history

  3. Provide detailed information for check() failures in actions

    @linh2931
    linh2931 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    bddb5ef View commit details
    Browse the repository at this point in the history

  4. Add deleting last finalizer key to update_elected_producers_finalizer… 

    …s_replaced_test
    @linh2931
    linh2931 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    9623905 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Do not limit number of producers consideered to be 30, to match with … 

    …update_elected_producers() implementation; replace hardcoded number 21 with ast_producer_schedule_size
    @linh2931
    linh2931 committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    dba03ea View commit details
    Browse the repository at this point in the history

  2. Use binary format as hashing key for finalizers table and do not stor… 

    …e the hash key
    @linh2931
    linh2931 committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    c16b95c View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Use a singlton to store last proposed finalizer keys to simplify code… 

    … logic and reasoning
    @linh2931
    linh2931 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    7a12d93 View commit details
    Browse the repository at this point in the history

  2. Allow unregistered producers to activate and delete their finalizer keys

    @linh2931
    linh2931 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    99ae2e3 View commit details
    Browse the repository at this point in the history

  3. Define a customized operator == in proposed_finalizer_key_t to simpli… 

    …fy checking finalizer policy changes
    @linh2931
    linh2931 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    7f2e940 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Change to use a caching mechanism to store last proposed finalizers t… 

    …o avoid unnecessay serialization of data in system contract constructor/destructor; always check if proposed finalizers are the same as last proposed ones
    @linh2931
    linh2931 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    ada26ea View commit details
    Browse the repository at this point in the history

  2. Use a single entry table for next finalizer key ID generator

    @linh2931
    linh2931 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    242de13 View commit details
    Browse the repository at this point in the history

  3. Add missing key_id update in the entry in last_proposed_finalizers fo… 

    …r just activated finalizer key improve comments
    @linh2931
    linh2931 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    9580f29 View commit details
    Browse the repository at this point in the history

  4. Provide a constructor for finalizer_auth_info to construct from final… 

    …izer_info
    @linh2931
    linh2931 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    c2aa777 View commit details
    Browse the repository at this point in the history

  5. Factor some common code

    @linh2931
    linh2931 committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    ceda65c View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Restore last proposed finalizers checks in tests

    @linh2931
    linh2931 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    8c72d60 View commit details
    Browse the repository at this point in the history

  2. Add a test to activate 3 keys of a finalizer in a row

    @linh2931
    linh2931 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    f9d72e3 View commit details
    Browse the repository at this point in the history

  3. Make get_last_proposed_finalizers() return a const& and avoid table l… 

    …ookup when it does not have a valuein subsequent calls
    @linh2931
    linh2931 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    a0acd15 View commit details
    Browse the repository at this point in the history

  4. Store _fin_key_id_generator.begin() in a variable to avoid multiple r… 

    …edundant calls
    @linh2931
    linh2931 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    7a0f1e1 View commit details
    Browse the repository at this point in the history

  5. Make set_proposed_finalizers argument a call-by-value

    @linh2931
    linh2931 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    b1f0a81 View commit details
    Browse the repository at this point in the history

  6. Small changes from comments

    @linh2931
    linh2931 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    65a54a4 View commit details
    Browse the repository at this point in the history

  7. Rename active_finalizer_key_id to active_key_id and active_finalizer_… 

    …key_binary to active_key_binary for shorter names
    @linh2931
    linh2931 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    be79752 View commit details
    Browse the repository at this point in the history

  8. Provide a utility method is_active to finalizer_key struct; add more … 

    …comments
    @linh2931
    linh2931 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    74f7a47 View commit details
    Browse the repository at this point in the history

  9. Make sure number of last proposed finalizers correct in tests

    @linh2931
    linh2931 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    e88b8ca View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Add public key check to last proposed finalizers in tests

    @linh2931
    linh2931 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    021213a View commit details
    Browse the repository at this point in the history

  2. Fix a couple fo typos in comments

    @linh2931
    linh2931 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    bc2e638 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #60 from AntelopeIO/core-contracts 

    IF: Add core contract actions to support Savanna
    @linh2931
    linh2931 authored Apr 15, 2024
    Configuration menu
    Copy the full SHA
    34f6854 View commit details
    Browse the repository at this point in the history