Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Instant finality updates #43

Merged
merged 106 commits into from
Apr 29, 2024
Merged

IF: Instant finality updates #43

merged 106 commits into from
Apr 29, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Jan 25, 2024 •
edited
Loading

Change Description

Corresponds to Savanna Consensus

Deployment Changes

API Changes

Documentation Additions

linh2931 and others added 30 commits December 11, 2023 09:58
@linh2931
add setfinalizer to eosio.bios
37e4b25
@linh2931
add tests for eosio.bios setfinalizer action
6eac8c2
@linh2931
add more comments to eosio.bios setfinalizer tests
7181593
@linh2931
update Leap and CDT versions for CICD
0d5cc0d
@linh2931
use std::move for argument passing
f91b47f
@linh2931
correct a typo of privileged
4e31832
@linh2931
update CDT asset-artifact-download-action from v2 to v3
37c4dc3
@linh2931
add apt-get update && apt-get upgrade -y before apt install
da83307
@linh2931
change leap-dev asset-artifact-download-action to v3
d9dceab
@linh2931
remove token usage
5b3c58e
@linh2931
correct comments about setfinalizer and add max_finalizers and max_fi…
d7f7616 
…nalizer_description_size definition
@linh2931
add checks for duplicate keys, too small threshold, weight sum overfl…
312f46a 
…ow, max_finalizers, and max_finalizer_description_size
@linh2931
add additional tests for setfinalizer input validation
d5bf241
@linh2931
simplify building long description in tests and add a test for descri…
8676a92 
…ption length equal to max allowed size
@linh2931
use affine raw format for key uniqueness check
ac597ea
@linh2931
move g1_hash and g1_equal inside function body and next to their use,…
89672ac 
… use std::hash<const char*> for hashing, use size() instead of 96 * sizeof(char)
@linh2931
Merge pull request #33 from AntelopeIO/setfinalizer
57218e4 
IF: Add setfinalizer action to eosio.bios
@heifner
GH-34 Update set_finalizer errors
afe749a
@heifner
Merge pull request #35 from AntelopeIO/GH-34-set-finalizer-errors
247b5c4 
Update set_finalizer errors
@heifner
GH-37 Update to use controller active_producers(0 instead of accessin…
a3ee2ed 
…g head_block_state.
@heifner
GH-37 Use cdt finalizer_authority
5e95bc2
@heifner
GH-37 Update to ubuntu-22.04
e28a8ee
@heifner
Merge remote-tracking branch 'origin/main' into merge-main-01-08-2023
4cab488
@heifner
Merge branch 'merge-main-01-08-2023' into GH-37-update-for-if
6a5be27
@heifner
GH-37 New block extension for instant finality
25d6b28
@heifner
Empty commit
cae6ac4
@heifner
GH-37 Rename variable to make clearer
889d3e9
@heifner
Merge pull request #38 from AntelopeIO/GH-37-update-for-if
0137e60 
IF: Update for latest IF
@heifner
Merge pull request #40 from AntelopeIO/merge-main-01-08-2023
b1a152d 
IF: Merge main 01-08-2023
@heifner
GH-41 Add verification that finalizer weight_sum is >= threshold
ea0835b
linh2931 and others added 27 commits April 6, 2024 21:07
@linh2931
Cache finalizer key binary form in finalizers table; improve descript…
c9b156d 
…ion of actions; various minor cleanups.
@linh2931
Simplilfy the update_elected_producers test and small clean ups
a2b44f4
@linh2931
Remove unnecessary set_proposed_producers related code in switosvnn()…
d5f68ad 
… action
@linh2931
Provide detailed information for check() failures in actions
bddb5ef
@linh2931
Add deleting last finalizer key to update_elected_producers_finalizer…
9623905 
…s_replaced_test
@linh2931
Do not limit number of producers consideered to be 30, to match with …
dba03ea 
…update_elected_producers() implementation; replace hardcoded number 21 with ast_producer_schedule_size
@linh2931
Use binary format as hashing key for finalizers table and do not stor…
c16b95c 
…e the hash key
@linh2931
Use a singlton to store last proposed finalizer keys to simplify code…
7a12d93 
… logic and reasoning
@linh2931
Allow unregistered producers to activate and delete their finalizer keys
99ae2e3
@linh2931
Define a customized operator == in proposed_finalizer_key_t to simpli…
7f2e940 
…fy checking finalizer policy changes
@linh2931
Change to use a caching mechanism to store last proposed finalizers t…
ada26ea 
…o avoid unnecessay serialization of data in system contract constructor/destructor; always check if proposed finalizers are the same as last proposed ones
@linh2931
Use a single entry table for next finalizer key ID generator
242de13
@linh2931
Add missing key_id update in the entry in last_proposed_finalizers fo…
9580f29 
…r just activated finalizer key improve comments
@linh2931
Provide a constructor for finalizer_auth_info to construct from final…
c2aa777 
…izer_info
@linh2931
Factor some common code
ceda65c
@linh2931
Restore last proposed finalizers checks in tests
8c72d60
@linh2931
Add a test to activate 3 keys of a finalizer in a row
f9d72e3
@linh2931
Make get_last_proposed_finalizers() return a const& and avoid table l…
a0acd15 
…ookup when it does not have a valuein subsequent calls
@linh2931
Store _fin_key_id_generator.begin() in a variable to avoid multiple r…
7a0f1e1 
…edundant calls
@linh2931
Make set_proposed_finalizers argument a call-by-value
b1f0a81
@linh2931
Small changes from comments
65a54a4
@linh2931
Rename active_finalizer_key_id to active_key_id and active_finalizer_…
be79752 
…key_binary to active_key_binary for shorter names
@linh2931
Provide a utility method is_active to finalizer_key struct; add more …
74f7a47 
…comments
@linh2931
Make sure number of last proposed finalizers correct in tests
e88b8ca
@linh2931
Add public key check to last proposed finalizers in tests
021213a
@linh2931
Fix a couple fo typos in comments
bc2e638
@linh2931
Merge pull request #60 from AntelopeIO/core-contracts
34f6854 
IF: Add core contract actions to support Savanna
@heifner heifner marked this pull request as ready for review April 29, 2024 18:53
@arhag arhag merged commit c8f1317 into main Apr 29, 2024
1 check passed
@arhag arhag deleted the instant-finality branch April 29, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heifner @arhag @linh2931