Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: Verify bls signature of vote while not holding a mutex #2359

Merged
merged 5 commits into from
Mar 29, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Mar 29, 2024

Since bls signature verification can take 6-8ms on ci/cd machines (~2ms on i7 or i9 12th gen), perform the verify while not holding a mutex. This reduces the contention on the pending_quorum_certificate mutex.

I believe we still need to do the verify off the net thread, but this is a simple improvement we can get in now.

This PR severely aggravated #2289, so added a fix for that issue.

Resolves #2289

@heifner heifner added the OCI Work exclusive to OCI team label Mar 29, 2024
@heifner heifner requested a review from greg7mdp March 29, 2024 21:18
@heifner heifner merged commit 3562c7d into hotstuff_integration Mar 29, 2024
34 checks passed
@heifner heifner deleted the verify-bls-sig-unlocked branch March 29, 2024 21:30
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Reduce lock contention during BLS signature verification.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IF: Update libtester framework to guarantee deterministic vote processing
4 participants