Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Update libtester framework to guarantee deterministic vote processing #2289

Closed
arhag opened this issue Mar 6, 2024 · 2 comments · Fixed by #2359
Closed

IF: Update libtester framework to guarantee deterministic vote processing #2289

arhag opened this issue Mar 6, 2024 · 2 comments · Fixed by #2359
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Instant Finality:...

Comments

@arhag
Copy link
Member

arhag commented Mar 6, 2024

Options:

  1. Provide a way to wait on votes (which happen on another thread normally).
  2. Or, provide a flag for the voting to occur on the main thread for tests.

This should resolve test instability in our Boost IF tests such as #2267.
@arhag arhag added the 👍 lgtm label Mar 6, 2024
@arhag arhag removed the triage label Mar 6, 2024
This was referenced Mar 6, 2024
Closed
Closed
@heifner
Copy link
Member

heifner commented Mar 9, 2024 •
edited
Loading

Example of recent failure that needs this change.
https://github.com/AntelopeIO/leap/actions/runs/8217721857/job/22473866034
https://github.com/AntelopeIO/leap/actions/runs/8217935569/job/22474256997
https://github.com/AntelopeIO/leap/actions/runs/8451853634/job/23151427693
https://github.com/AntelopeIO/leap/actions/runs/8473570201/job/23218612746
https://github.com/AntelopeIO/leap/actions/runs/8480643372/job/23237011564
https://github.com/AntelopeIO/leap/actions/runs/8481222101/job/23238464958

@linh2931
Copy link
Member

Haven't seen this for a while, but it happened today:
https://github.com/AntelopeIO/leap/actions/runs/8459917557/job/23177381955?pr=2349#step:5:4043

@heifner heifner self-assigned this Mar 29, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Mar 29, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Mar 29, 2024
@heifner heifner mentioned this issue Mar 29, 2024
Merged
@heifner heifner linked a pull request Mar 29, 2024 that will close this issue
IF: Verify bls signature of vote while not holding a mutex #2359
Merged
@heifner heifner closed this as completed Mar 29, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Instant Finality: Production-Ready
Development

Successfully merging a pull request may close this issue.

IF: Verify bls signature of vote while not holding a mutex AntelopeIO/leap
4 participants
@heifner @arhag @linh2931 @enf-ci-bot