Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Sign and verify signature of proposed blocks #2241

Merged
merged 5 commits into from
Feb 19, 2024
Merged

IF: Sign and verify signature of proposed blocks #2241

merged 5 commits into from
Feb 19, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Feb 18, 2024

Sign block_id of proposed blocks and verify signatures on validation nodes.

  • Also adds validation of activated protocol features.
  • Includes a test that protocol feature activation works after instant_finality is enabled.
  • Existing tests cover block signing validation. Many tests failed when I signed with the wrong producer key.

Resolves #2142

@heifner heifner linked an issue Feb 18, 2024 that may be closed by this pull request
IF: sign blocks and verify signature of blocks #2142
Closed
@heifner heifner requested review from greg7mdp and linh2931 February 18, 2024 03:32
greg7mdp
greg7mdp approved these changes Feb 18, 2024
View reviewed changes
Copy link
Contributor

@greg7mdp greg7mdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice test for protocol feature activation under savanna.

linh2931
linh2931 requested changes Feb 18, 2024
View reviewed changes
Copy link
Member

@linh2931 linh2931 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe later add a test for rejecting unsigned blocks?

libraries/chain/block_header_state.cpp Outdated Show resolved Hide resolved
libraries/chain/block_state.cpp Outdated Show resolved Hide resolved
libraries/chain/block_state.cpp Outdated Show resolved Hide resolved
libraries/chain/block_state.cpp Outdated Show resolved Hide resolved
libraries/chain/block_state.cpp Outdated Show resolved Hide resolved
libraries/chain/block_state.cpp Outdated Show resolved Hide resolved
@heifner heifner requested a review from linh2931 February 19, 2024 13:51
@heifner heifner added the OCI Work exclusive to OCI team label Feb 19, 2024
@heifner heifner merged commit d6db03c into hotstuff_integration Feb 19, 2024
26 checks passed
@heifner heifner deleted the GH-2142-sign branch February 19, 2024 14:58
@heifner heifner mentioned this pull request Feb 19, 2024
Closed
@heifner heifner changed the title IF: Sign and verify signature or proposed blocks IF: Sign and verify signature of proposed blocks Feb 19, 2024
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Sign block_id of proposed blocks and verify signatures on validation nodes.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IF: sign blocks and verify signature of blocks
4 participants
@heifner @ericpassmore @greg7mdp @linh2931