Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: sign blocks and verify signature of blocks #2142

Closed
Tracked by #2110
heifner opened this issue Jan 25, 2024 · 2 comments · Fixed by #2241
Closed
Tracked by #2110

IF: sign blocks and verify signature of blocks #2142

heifner opened this issue Jan 25, 2024 · 2 comments · Fixed by #2241
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Leap v6.0.0-rc1

Comments

@heifner
Copy link
Member

heifner commented Jan 25, 2024

Currently hotstuff_integration branch does not sign or verify signature of proposed blocks after instant finality enabled.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jan 25, 2024
@arhag arhag mentioned this issue Jan 25, 2024
Closed
@arhag
Copy link
Member

arhag commented Jan 25, 2024

After IF, the proposer can just sign the block ID.

@arhag arhag added 👍 lgtm and removed triage labels Jan 25, 2024
@BenjaminGormanPMP BenjaminGormanPMP added this to the Leap v6.0.0-rc1 milestone Jan 30, 2024
@arhag arhag assigned heifner and unassigned greg7mdp Feb 14, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Feb 16, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Feb 16, 2024
heifner added a commit that referenced this issue Feb 17, 2024
@heifner
GH-2142 Sign proposed blocks with producer signature and verify signe…
d558816 
…d blocks. Also validate new protocol features.
heifner added a commit that referenced this issue Feb 17, 2024
@heifner
GH-2142 Sign the correct block and store in the correct signed_block_…
89c65ab 
…header
heifner added a commit that referenced this issue Feb 18, 2024
@heifner
GH-2142 Use the correct producer schedule for finding block signing a…
83ec46f 
…uthorization.
heifner added a commit that referenced this issue Feb 18, 2024
@heifner
GH-2142 Add test that protocol feature activation works after instant…
fa55806 
…_finality enabled.
@heifner heifner mentioned this issue Feb 18, 2024
Merged
@heifner heifner linked a pull request Feb 18, 2024 that will close this issue
IF: Sign and verify signature of proposed blocks #2241
Merged
heifner added a commit that referenced this issue Feb 19, 2024
@heifner
GH-2142 Update comments and provide better error logs on failure
1ae22df
heifner added a commit that referenced this issue Feb 19, 2024
@heifner
Merge pull request #2241 from AntelopeIO/GH-2142-sign
d6db03c 
IF: Sign and verify signature or proposed blocks
@heifner
Copy link
Member Author

heifner commented Feb 19, 2024

Resolved by #2241

@heifner heifner closed this as completed Feb 19, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Leap v6.0.0-rc1
Development

Successfully merging a pull request may close this issue.

IF: Sign and verify signature of proposed blocks AntelopeIO/leap
5 participants
@greg7mdp @heifner @arhag @enf-ci-bot @BenjaminGormanPMP