Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2 -> 4.0] change HTTP code on exceedinghttp-max-bytes-in-flight-mb or http-max-in-flight-requests to 503 #2205

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

spoonincode
Copy link
Member

merge #2199 in to 4.0.

4xx response codes are for errors caused by the client where 5xx is for errors on the server side. The server exceeding its configured resource quota should be a 5xx error not a 4xx error. Change this from 429 to 503 (which is what it was in 2.0, fwiw). A 5xx error in this condition makes it easier for failover tooling, among other things. Resolves #2129

@ericpassmore
Copy link
Contributor

Note:start
group: PROTOCOL
category: HTTP
summary: 503 is now the HTTP error return code for exceeding http-max-bytes-in-flight-mb or http-max-in-flight-requests. Previous code was 429.
Note: end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review status code when http-max-bytes-in-flight-mb is reached
4 participants