Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0 -> 5.0] change HTTP code on exceeding http-max-bytes-in-flight-mb or http-max-in-flight-requests to 503 #2206

Merged
merged 5 commits into from
Feb 5, 2024
Merged

[4.0 -> 5.0] change HTTP code on exceeding http-max-bytes-in-flight-mb or http-max-in-flight-requests to 503 #2206

merged 5 commits into from
Feb 5, 2024

Conversation

spoonincode
Copy link
Member

Merges #2199 & #2205 in to 5.0,

4xx response codes are for errors caused by the client where 5xx is for errors on the server side. The server exceeding its configured resource quota should be a 5xx error not a 4xx error. Change this from 429 to 503 (which is what it was in 2.0, fwiw). A 5xx error in this condition makes it easier for failover tooling, among other things. Resolves #2129

@spoonincode
change max inflight bytes/requests from 429 to 503
a82f152
@spoonincode
Merge pull request #2199 from AntelopeIO/http_max_429to503_32
5b0eba2 
[3.2] change HTTP code on exceeding `http-max-bytes-in-flight-mb` or `http-max-in-flight-requests` to 503
@spoonincode
Merge remote-tracking branch 'origin/release/3.2' into HEAD
8a0388f
@spoonincode
Merge pull request #2205 from AntelopeIO/http_max_429to503_40
5984add 
[3.2 -> 4.0] change HTTP code on exceeding`http-max-bytes-in-flight-mb` or `http-max-in-flight-requests` to 503
@spoonincode
Merge remote-tracking branch 'origin/release/4.0' into HEAD
ba04659
@spoonincode spoonincode merged commit 3394e0b into release/5.0 Feb 5, 2024
29 checks passed
@spoonincode spoonincode deleted the http_max_429to503_50 branch February 5, 2024 19:21
@spoonincode spoonincode mentioned this pull request Feb 5, 2024
Merged
@spoonincode spoonincode linked an issue Feb 5, 2024 that may be closed by this pull request
Review status code when http-max-bytes-in-flight-mb is reached #2129
Closed
@heifner heifner added this to the Leap v5.0.1 milestone Feb 6, 2024
@ericpassmore
Copy link
Contributor

Note:start
group: PROTOCOL
category: HTTP
summary: 503 is now the HTTP error return code for exceeding http-max-bytes-in-flight-mb or http-max-in-flight-requests. Previous code was 429.
Note: end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Leap v5.0.1
Development

Successfully merging this pull request may close these issues.

Review status code when http-max-bytes-in-flight-mb is reached
4 participants
@spoonincode @ericpassmore @greg7mdp @heifner