IF: accumulate the weight in vote calculation #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
requested changes
Jan 24, 2024
|
Note:start |
greg7mdp
approved these changes
Jan 30, 2024
unittests/block_state_tests.cpp
Outdated
| @@ -96,7 +191,7 @@ BOOST_AUTO_TEST_CASE(verify_qc_test) try { | |||
| digest_type strong_digest(fc::sha256("0000000000000000000000000000002")); | |||
| std::vector<uint8_t> strong_digest_data(strong_digest.data(), strong_digest.data() + strong_digest.data_size()); | |||
| digest_type weak_digest(fc::sha256("0000000000000000000000000000003")); | |||
| std::vector<uint8_t> weak_digest_data(weak_digest.data(), weak_digest.data() + weak_digest.data_size()); | |||
| std::vector<uint8_t> weak_digest_data(weak_digest.data(), weak_digest.data() + weak_digest. data_size()); | |||
There was a problem hiding this comment.
the spaces after weak_digest. seem to be a mistake.
There was a problem hiding this comment.
Thanks for noticing this!
|
Not related to your changes, but looks like we have a real issue with this test: |
heifner
approved these changes
Jan 30, 2024
libraries/chain/include/eosio/chain/hotstuff/finalizer_policy.hpp
Outdated
Show resolved
Hide resolved
heifner
approved these changes
Jan 30, 2024
greg7mdp
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the weak and strong vote calculations, it is assuming they are all of equal weight. It needs to refer to the weights in the finalizer policy to determine how to accumulate the weight.
Resolved #2084