Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: accumulated weight calculation #2084

Closed
Tracked by #2110
linh2931 opened this issue Jan 13, 2024 · 0 comments · Fixed by #2131
Closed
Tracked by #2110

IF: accumulated weight calculation #2084

linh2931 opened this issue Jan 13, 2024 · 0 comments · Fixed by #2131
Assignees

Comments

@linh2931
Copy link
Member

linh2931 commented Jan 13, 2024

From @arhag in reviewing #2076:

I'm realizing there is a problem with the weak and strong vote calculations. It is assuming they are all of equal weight. But that isn't necessarily true. It needs to refer to the weights in the finalizer policy to determine how to accumulate the weight.

@bhazzard bhazzard added 👍 lgtm and removed triage labels Jan 16, 2024
@linh2931 linh2931 self-assigned this Jan 22, 2024
@linh2931 linh2931 added this to the Leap v6.0.0-rc1 milestone Jan 22, 2024
@BenjaminGormanPMP BenjaminGormanPMP moved this from Todo to In Progress in Team Backlog Jan 22, 2024
@linh2931 linh2931 moved this from In Progress to Awaiting Review in Team Backlog Jan 24, 2024
@linh2931 linh2931 linked a pull request Jan 24, 2024 that will close this issue
@linh2931 linh2931 moved this from Awaiting Review to Done in Team Backlog Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants