Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF:Unification: Process received Vote message #2073

Merged
merged 15 commits into from
Jan 17, 2024
Merged

IF:Unification: Process received Vote message #2073

merged 15 commits into from
Jan 17, 2024

Conversation

linh2931
Copy link
Member

Process vote messages received from net plugin:

  • aggregated the vote signature into the pending QC for the block the vote corresponds to
  • added tests

Changing proposal_id to block_id in vote message and removing proposal_digest from pending_quorum_certificate will be done after unification as they should be part of the bigger cleaning up effort: AntelopeIO/spring#12

Resolved #2046

Replaced #2067

@linh2931 linh2931 mentioned this pull request Jan 11, 2024
Closed
@linh2931 linh2931 requested review from heifner and greg7mdp January 11, 2024 14:14
@linh2931 linh2931 linked an issue Jan 11, 2024 that may be closed by this pull request
IF: Unification: Integrate vote message signatures into new fork database #2046
Closed
greg7mdp
greg7mdp requested changes Jan 11, 2024
View reviewed changes
libraries/chain/block_state.cpp Outdated Show resolved Hide resolved
greg7mdp
greg7mdp previously approved these changes Jan 11, 2024
View reviewed changes
heifner
heifner requested changes Jan 12, 2024
View reviewed changes
libraries/chain/block_state.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/hotstuff/hotstuff.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/include/eosio/chain/block_state.hpp Outdated Show resolved Hide resolved
plugins/net_plugin/net_plugin.cpp Show resolved Hide resolved
plugins/net_plugin/net_plugin.cpp Show resolved Hide resolved
@greg7mdp greg7mdp dismissed their stale review January 12, 2024 14:25

I'd like to have another look after Kevin's requested changes are made.

@linh2931 linh2931 requested review from heifner and greg7mdp January 16, 2024 15:06
@linh2931
provide pending_quorum_certificate::to_valid_quorum_certificate() for…
c3e2f00 
… easier thread safety; remove valid_quorum_certificate(const pending_quorum_certificate&)
greg7mdp
greg7mdp reviewed Jan 16, 2024
View reviewed changes
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
libraries/chain/controller.cpp Outdated Show resolved Hide resolved
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Process vote messages received from net plugin by aggregating signatures into the pending QC for the corresponding block.
Note: end

@linh2931 linh2931 requested a review from heifner January 17, 2024 13:56
@linh2931 linh2931 requested a review from greg7mdp January 17, 2024 13:56
@linh2931 linh2931 merged commit 8cf39ec into hotstuff_integration Jan 17, 2024
26 checks passed
@linh2931 linh2931 deleted the vote_message_receive branch January 17, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IF: Unification: Integrate vote message signatures into new fork database
4 participants
@linh2931 @ericpassmore @greg7mdp @heifner