Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Unification: Integrate vote message signatures into new fork database #2046

Closed
Tracked by #1508
arhag opened this issue Jan 5, 2024 · 0 comments · Fixed by #2073
Closed
Tracked by #1508

IF: Unification: Integrate vote message signatures into new fork database #2046

arhag opened this issue Jan 5, 2024 · 0 comments · Fixed by #2073
Assignees
@linh2931
Labels
👍 lgtm

Comments

@arhag
Copy link
Member

arhag commented Jan 5, 2024 •
edited
Loading

Vote messages received from net plugin should be processed by some code in libchain, which can be included in source code within the finality directory (renamed from hotstuff) within chain. This processing involves aggregating the vote signature into the pending QC for the block the vote corresponds to. This pending QC lives within the block_state kept within the new fork database.
@arhag arhag mentioned this issue Jan 5, 2024
Closed
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jan 5, 2024
@arhag arhag added 👍 lgtm and removed triage labels Jan 5, 2024
This was referenced Jan 5, 2024
Closed
Closed
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Jan 9, 2024
@linh2931 linh2931 mentioned this issue Jan 10, 2024
Closed
@linh2931 linh2931 moved this from In Progress to Awaiting Review in Team Backlog Jan 10, 2024
@linh2931 linh2931 linked a pull request Jan 10, 2024 that will close this issue
IF:Unification: Integrate vote message signatures into new fork database #2067
Closed
@linh2931 linh2931 mentioned this issue Jan 11, 2024
Merged
@linh2931 linh2931 removed a link to a pull request Jan 11, 2024
IF:Unification: Integrate vote message signatures into new fork database #2067
Closed
@linh2931 linh2931 linked a pull request Jan 11, 2024 that will close this issue
IF:Unification: Process received Vote message #2073
Merged
@linh2931 linh2931 moved this from Awaiting Review to Done in Team Backlog Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
👍 lgtm
Projects
Team Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IF:Unification: Process received Vote message AntelopeIO/leap
3 participants
@arhag @linh2931 @enf-ci-bot