Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: Remove unneeded files #2049

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Jan 5, 2024

  • finalizer_policy.cpp only exists for the following reason, which is no longer applicable
/**

These definitions are all here to avoid including bls_public_key.hpp which includes <bls12- 381/bls12-381.hpp>
and pulls in bls12-381 types. This keeps bls12-381 out of libtester.
*/
  • proposal_info.hpp was for proposal_info_extension which has been folded into instant_finality_extension.

Remove them from code base to have less clutters.

Resolved #2044

@linh2931 linh2931 requested review from greg7mdp and heifner January 5, 2024 21:29
@greg7mdp
Copy link
Contributor

greg7mdp commented Jan 5, 2024

~~I seem to remember that @heifner had created this on purpose to avoid including the bls12 headers somewhere (was it contracts?). ~~
OK, just saw the comment I missed.

@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: CHORE
summary: Consolidation and refactoring created some un-needed files. This PR removed those un-needed files.
Note:end

@linh2931 linh2931 merged commit 965a9fa into hotstuff_integration Jan 6, 2024
26 checks passed
@linh2931 linh2931 deleted the remove_unneeded_files branch January 6, 2024 18:41
@linh2931 linh2931 linked an issue Jan 6, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IF: remove unneeded files
4 participants