Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: remove unneeded files #2044

Closed
Tracked by #1508
linh2931 opened this issue Jan 5, 2024 · 0 comments · Fixed by #2049
Closed
Tracked by #1508

IF: remove unneeded files #2044

linh2931 opened this issue Jan 5, 2024 · 0 comments · Fixed by #2049
Assignees

Comments

@linh2931
Copy link
Member

linh2931 commented Jan 5, 2024

  • finalizer_policy.cpp only exists for the following reason, which is no longer applicable
  /**
    * These definitions are all here to avoid including bls_public_key.hpp which includes <bls12-   381/bls12-381.hpp>
    * and pulls in bls12-381 types. This keeps bls12-381 out of libtester.
    */
  • proposal_info.hpp was for proposal_info_extension which has been folded into instant_finality_extension.

Remove them from code base to have less cluters.

@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jan 5, 2024
@arhag arhag added 👍 lgtm and removed triage labels Jan 5, 2024
@linh2931 linh2931 linked a pull request Jan 6, 2024 that will close this issue
@linh2931 linh2931 moved this from Todo to Done in Team Backlog Jan 6, 2024
@arhag arhag closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants