-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IF: Unification: Add block header extension #1911
Comments
Merged
greg7mdp
added a commit
that referenced
this issue
Dec 15, 2023
The test can be re-enabled when #1911 is completed.
I have finished this issue in my branch gh_2034. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Depends on #1881 and #1941.
The block header extension should carry the new information needed for a proposal:
last_qc_block_num
: The block height of the most recent ancestor block that has a QC.is_last_qc_strong
: This is a boolean that determines if the QC justification for the block referenced by last QC block height is strong or weak.new_finalizer_policy
: The new finalizer policy proposed in the block (may be nullopt).new_proposer_policy
: The new proposer policy proposed in the block (may be nullopt).Example:
This should replace the extensions
finalizer_policy_extension
andproposal_info_extension
.Use the status of the
pending_quorum_certificate
to determine whether you have a valid QC and if so whether it is strong or weak. That determines the values oflast_qc_block_num
andis_last_qc_strong
.Use the most recent ancestor block that has a valid QC (whether the status is
strong
,weak_final
, orweak_achieved
) as the block referenced bylast_qc_block_num
.The actual QC does not need to be included yet in a block extension. That will be handled in a separate issue.
The text was updated successfully, but these errors were encountered: