Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IStudyLoader return unique_ptr as expected of a factory #2038

Closed
wants to merge 1 commit into from
Closed

IStudyLoader return unique_ptr as expected of a factory #2038

wants to merge 1 commit into from

Conversation

JasonMarechal25
Copy link
Contributor

Had to make Study and all encapsulated objects movable to do so

@JasonMarechal25
IStudyLoader return unique_ptr
6e48813 
Make Study and its hierarchy movable
@JasonMarechal25 JasonMarechal25 marked this pull request as draft April 16, 2024 07:29
@JasonMarechal25 JasonMarechal25 requested a review from a team April 16, 2024 07:29
@JasonMarechal25 JasonMarechal25 mentioned this pull request Apr 16, 2024
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
4.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@JasonMarechal25
Copy link
Contributor Author

Finally change is smaller that anticipated and can be made directly inside #1993

@JasonMarechal25 JasonMarechal25 deleted the feature/IStudyLoader_unique_ptr branch April 16, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-zakir a-zakir a-zakir approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonMarechal25 @a-zakir