Expose API [ANT-1158] #1993
Merged
Expose API [ANT-1158] #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvlecl
reviewed
Mar 18, 2024
src/libs/antares/study-loader/include/antares/study-loader/IStudyLoader.h
Outdated
Show resolved
Hide resolved
JasonMarechal25
force-pushed
the
feature/expose-api
branch
3 times, most recently
from
079f4bf to
cab2675
Compare
sylvlecl
reviewed
Apr 12, 2024
src/libs/antares/study-loader/include/antares/study-loader/IStudyLoader.h
Outdated
Show resolved
Hide resolved
sylvlecl
reviewed
Apr 12, 2024
src/solver/simulation/include/antares/solver/simulation/solver.h
Outdated
Show resolved
Hide resolved
| * | ||
| * This class is responsible for translating a weekly problem to a linear programming problem. | ||
| */ | ||
| class HebdoProblemToLpsTranslator |
There was a problem hiding this comment.
It would make more sense to have plain functions here than a class:
there is no undrlying state to maintain, we don't need an object here, it's only functions with an input and an output.
Nice ref about free functions :) : https://www.youtube.com/watch?v=WLDT1lDOsb4
There was a problem hiding this comment.
I understand however I tend to prefer to stick to OOP paradigme in case I must stub behavior. I can do the change if required though because atm there is no stubing required
(didn't watch the video yet)
JasonMarechal25
changed the base branch from
develop
to
feature/remove_fetch_content
JasonMarechal25
force-pushed
the
feature/expose-api
branch
from
fe91194 to
ce7675c
Compare
- Simplify the code by not renaming the process. - Rename "IO::parentPath" to "IO::parent_path" to match std signature.
# Conflicts: # .github/workflows/ubuntu.yml # src/CMakeLists.txt # src/solver/simulation/include/antares/solver/simulation/solver.hxx
flomnes
approved these changes
Jun 21, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose Antares Solver in a library. the library and target are called AntaresAPI. This API expose one entry point to run a simulation on a study. The return value of this is a data structure with the path to the simulation and the weekly problems.