feature(installer): update installer version and improve desktop version launcher #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Otherwise, alembic is actually launched after the gui.py script ends. We still need to analyze dependencies of all alembic scripts though. Also, make the application exit when the server process ends. Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
sylvlecl
changed the title
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
MartinBelthle
previously approved these changes
Oct 2, 2024
.github/workflows/deploy.yml
Outdated
| @@ -4,6 +4,7 @@ on: | |||
| branches: | |||
| - "master" | |||
| - "hotfix/**" | |||
| - "feature/update-installer" | |||
There was a problem hiding this comment.
Should be removed or we could add more generic branch name such as installer/** or deploy/**
| migration_files = [str(f) for f in migrations_dir.iterdir() if f.is_file() and f.suffix == '.py'] | ||
| # We need to analyze all alembic files to be sure the migration phase works fine: | ||
| # alembic loads version files by their path, so we need to add them as "data" to the package, | ||
| # but all the dependencies they use need to be included also, wo we need to perform a |
| binaries=binaries, | ||
| datas=[('./resources', './resources'), ('./alembic', './alembic')], | ||
| binaries=[], | ||
| datas=[('./resources', './resources'), ('./alembic', './alembic'), ('./alembic.ini', './')], |
There was a problem hiding this comment.
Before we had this: binaries = [('./alembic.ini', './alembic.ini')] which created a folder called "alembic.ini" in which the file was placed.
Now the file is correctly placed at the root
| migration_files = [str(f) for f in migrations_dir.iterdir() if f.is_file() and f.suffix == '.py'] | ||
| # We need to analyze all alembic files to be sure the migration phase works fine: | ||
| # alembic loads version files by their path, so we need to add them as "data" to the package, | ||
| # but all the dependencies they use need to be included also, wo we need to perform a |
antarest/gui.py
Outdated
| quit_action.triggered.connect(app.quit) | ||
|
|
||
| # Adding options to the System Tray | ||
| def handle_action(reason: int) -> None: |
There was a problem hiding this comment.
This function/design is really weird but I'm far from understanding this file
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alembic must not be defined as a script, otherwise it's executed when the application
quits. Instead, it must just be analyzed separately to get its dependencies