Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(study-factory): ignore non-existent files in archived studies during build #1871

Merged

Conversation

laurent-laporte-pro
Copy link
Contributor

@laurent-laporte-pro laurent-laporte-pro commented Dec 20, 2023

Description

Fixes issue: Unexpected server error: "There is no item named 'settings/generaldata.ini' in the archive"

Changes Made

  • Ignore non-existent files in the ZIP archive, such as renewable cluster configuration files.
  • Avoid parsing renewable cluster configuration, when the study version is less than 8.1.
  • Optimize reading configuration from within an INI file to eliminate the need for decompressing into a temporary directory. Decompression now occurs in memory, resulting in faster processing.

How to Test

  1. Attempt to open an archived study with a version less than to 8.1.
  2. Verify that the application no longer displays the "Unexpected server error" error.
  3. Confirm that the study opens successfully without any issues.

Screenshots

image

Checklist

  • I have tested these changes locally.
  • I have updated existing documentation (docstring and comments).
  • I have ensured that my code follows the project's coding standards.

hdinia
hdinia previously approved these changes Jan 4, 2024
@laurent-laporte-pro laurent-laporte-pro force-pushed the hotfix/ignore-non-existent-files-in-archived-studies branch from c5062bf to 327f019 Compare January 4, 2024 10:33
@laurent-laporte-pro laurent-laporte-pro merged commit 68bda77 into dev Jan 4, 2024
7 of 8 checks passed
@laurent-laporte-pro laurent-laporte-pro deleted the hotfix/ignore-non-existent-files-in-archived-studies branch January 4, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end performance Improvement of performance (database and filesystem access) size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to unarchive a study
2 participants