Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(service): support import for outputs generated by the solver with the -z option #1774

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

feat(service): support import for outputs generated by the solver with the -z option #1774

wants to merge 6 commits into from
+65 −50

Conversation

MartinBelthle
Copy link
Contributor

@MartinBelthle MartinBelthle commented Oct 16, 2023 •
edited
Loading

This PR is linked to the MR feature/use-simulator-zip on antares-cd.

In order to validate this PR we should launch studies with and without:

  • xpress
  • auto_unzip option
  • xpansion
  • xpansion with sensitivity
  • study.version higher and lower than v8.4

Also, we should check that the local launcher works.

I've performed all these tests on my local environment and they passed.

@commit-lint
Copy link

commit-lint bot commented Oct 16, 2023 •
edited
Loading

Features

  • xpansion: add support for xpansion outputs (153dd93)
  • service: add support for any alone output import (d05b0d0)

Bug Fixes

  • tests: correct tests with new behavior (93686e7)
  • import: change import condition since antares-launcher code changed (c0df77c)
  • service: adapt code and tests for new antares-launcher behavior (454ee96)

Contributors

MartinBelthle

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@MartinBelthle MartinBelthle linked an issue Oct 16, 2023 that may be closed by this pull request
[ANT-583] Improve retrieval of simulation results (option -z) #1738
Open
@MartinBelthle MartinBelthle changed the title [ANT-583] support import for outputs generated by the solver option -z [ANT-583] support import for outputs generated by the solver wiith the option -z Oct 16, 2023
@MartinBelthle MartinBelthle changed the title [ANT-583] support import for outputs generated by the solver wiith the option -z feat(service): support import for outputs generated by the solver wiith the option -z Oct 16, 2023
@MartinBelthle MartinBelthle changed the title feat(service): support import for outputs generated by the solver wiith the option -z feat(service): support import for outputs generated by the solver with the option -z Oct 16, 2023
@MartinBelthle MartinBelthle mentioned this pull request Oct 18, 2023
Merged
@MartinBelthle MartinBelthle self-assigned this Nov 6, 2023
@watermelon-copilot-for-code-review watermelon-copilot-for-code-review bot mentioned this pull request Dec 13, 2023
Merged
@laurent-laporte-pro laurent-laporte-pro force-pushed the feat/ANT-583-import-output-zipped-that-are-alone branch from 884d45a to 8d966b9 Compare December 19, 2023 20:56
@laurent-laporte-pro laurent-laporte-pro changed the title feat(service): support import for outputs generated by the solver with the option -z feat(service): support import for outputs generated by the solver with the -z option Dec 19, 2023
@laurent-laporte-pro
Copy link
Contributor

laurent-laporte-pro commented Dec 19, 2023 •
edited
Loading

This PR requires Antares-Launcher version 1.4 or above.

❗⚠❗ This feature must be tested on integration server

@watermelon-copilot-for-code-review watermelon-copilot-for-code-review bot mentioned this pull request Jan 2, 2024
Merged
@MartinBelthle MartinBelthle force-pushed the feat/ANT-583-import-output-zipped-that-are-alone branch from 3bb9d7b to a3bd4b3 Compare May 17, 2024 15:16
@MartinBelthle MartinBelthle removed the request for review from laurent-laporte-pro June 14, 2024 08:12
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MartinBelthle MartinBelthle

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ANT-583] Improve retrieval of simulation results (option -z)
2 participants
@MartinBelthle @laurent-laporte-pro