Fix new release GH workflow #1860
Conversation
Watermelon AI SummaryAI Summary deactivated by a-zakir GitHub PRs
Antares_Simulator is an open repo and Watermelon will serve it for free. |
|
Please retry analysis of this Pull-Request directly on SonarCloud |
.github/workflows/new_release.yml
Outdated
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| tag: ${{ github.event.inputs.release_tag }} | ||
| title: ${{ github.event.inputs.release_name }} | ||
| run: | | ||
| gh release create "$tag" \ | ||
| --repo="$GITHUB_REPOSITORY" \ | ||
| --title="$title" \ | ||
| --generate-notes |
There was a problem hiding this comment.
| env: | |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| tag: ${{ github.event.inputs.release_tag }} | |
| title: ${{ github.event.inputs.release_name }} | |
| run: | | |
| gh release create "$tag" \ | |
| --repo="$GITHUB_REPOSITORY" \ | |
| --title="$title" \ | |
| --generate-notes | |
| env: | |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| tag: ${{ github.event.inputs.release_tag }} | |
| title: ${{ github.event.inputs.release_name }} | |
| tests: ${{ github.event.inputs.run-tests }} | |
| run: | | |
| gh release create "$tag" \ | |
| --repo="$GITHUB_REPOSITORY" \ | |
| --title="$title" \ | |
| --notes="Run tests: $tests" |
The generated notes are garbage since our history is not linear. Also, we want to sort changes by type (new feature, bugfix, doc, code cleaning, etc.)
|
Almost good ! PDF doc is missing |
This reverts commit 3bcc2f8.
Co-authored-by: Florian Omnès <[email protected]>
| gh release create "$tag" \ | ||
| --repo="$GITHUB_REPOSITORY" \ | ||
| --title="$title" | ||
| --notes="Run tests: $tests" |
There was a problem hiding this comment.
You forgot to define $tests above (section env)
|
No description provided.