[cascading] from release/11.4.0-rc to main #2435
Merged
Commits on Nov 8, 2024
-
-
-
-
fix(2396): metadata checks should run on prerelease tags (#2431)
## Proposed change Retrofit #2397 ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> *- No issue associated -* <!-- * 🐛 Fix #issue --> <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- *
Pull Request #issue --> -
-
-
fix: metadata checks run on the wrong prerelease (#2434)
## Proposed change When running the metadata checks we use the version in the JSON migration file to compute the range that will be used to get the previous version. E.g. version `11.1.0` will generate the range `<11.1.0` with `{includePrerelease: true}` Unfortunately, this range include the prereleases of the current version `11.1.0-alpha.0` We want to include the prerelease of the previous versions but not of the current The solution is to add `-a` in the range to exclude them -> `<11.1.0-a` ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> *- No issue associated -* <!-- * 🐛 Fix #issue --> <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- * Pull Request #issue --> -
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.