[cascading] from release/11.4.0-rc to main #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![otter-cascading[bot]](https://avatars.githubusercontent.com/in/318094?s=60&v=4){kind=small}
## Proposed change Retrofit #2397 ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> *- No issue associated -* <!-- * 🐛 Fix #issue --> <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- *Pull Request #issue -->
## Proposed change
When running the metadata checks we use the version in the JSON
migration file to compute the range that will be used to get the
previous version.
E.g. version `11.1.0` will generate the range `<11.1.0` with
`{includePrerelease: true}`
Unfortunately, this range include the prereleases of the current version
`11.1.0-alpha.0`
We want to include the prerelease of the previous versions but not of
the current
The solution is to add `-a` in the range to exclude them -> `<11.1.0-a`
## Related issues
<!--
Please make sure to follow the [contribution
guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md)
-->
*- No issue associated -*
<!-- * 🐛 Fix #issue -->
<!-- * 🐛 Fix resolves #issue -->
<!-- * 🚀 Feature #issue -->
<!-- * 🚀 Feature resolves #issue -->
<!-- * Pull Request #issue -->
fpaul-1A
approved these changes
Nov 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
kpanot
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cascading from release/11.4.0-rc to main
The configuration requests the cascading to bypass reviewer in case of CI success.
To not bypass the reviewing process, please check the following checkbox:
This Pull Request has been generated with ❤️ by the Otter cascading tool.