Feature/table #2593
Draft
Feature/table #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-react into feature/table
Co-authored-by: Camilla Marie Dalan <[email protected]>
| - Makes refactoring the app framework a lot harder. | ||
| - Leads to unclear interfaces between UI components and the app framework. | ||
| - Makes developing UI components complex without deep understanding of the application. | ||
|
|
There was a problem hiding this comment.
Suggested change
| - Enables sharing of pure components (docs, Studio, ???) |
?
|
As ADRs are introduced here, it would be convenient to add the template.md file to the adr folder 🙌 |
|
|
||
| - Makes it hard to do component testing outside a fully rendered app. | ||
| - Makes refactoring the app framework a lot harder. | ||
| - Leads to unclear interfaces between UI components and the app framework. |
There was a problem hiding this comment.
Would be nice to have linked examples of code/components for some of these points, I'm sure you've discussed and looked at tons of examples here to inform this assertion but for myself presently and future readers it would be helpful to know the context here 😄
bjosttveit
reviewed
Oct 18, 2024
| A list of decision drivers. These are points which can differ in importance. If a point is "nice to have" rather than | ||
| "need to have", then prefix the description. | ||
|
|
||
| - B1: UI components should only receive data to display, notify the app when data is changed, and notify validity of user input. |
There was a problem hiding this comment.
Suggested change
| - B1: UI components should only receive data to display, notify the app when data is changed, and notify validity of user input. | |
| - B1: UI components should only receive data to display, and notify the app when data is changed. |
I suggest that we remove the validation of user input part, as it makes little sense to leave this to UI components in our context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Verification/QA
kind/*label to this PR for proper release notes grouping