Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor components to app-components #2616

Open
adamhaeger opened this issue Oct 22, 2024 · 0 comments
Open

Refactor components to app-components #2616

adamhaeger opened this issue Oct 22, 2024 · 0 comments

Comments

@adamhaeger
Copy link
Contributor

Description

As decided in the ADR in this PR:

#2593

we will refactor our components into dumb UI components.

Please see the ADR for the reasons for this.

In scope

For each of our layout components:

  1. Create a 'dumb' component in the /src/app-components folder
  2. The component should receive and display data, receive and display isValid status.
  3. The component should not have any dependencies on the rest of the app, it should be able to be moved out of src as a lib at any time.
  4. There should remain a slim component inside /layout that resolves the data for the compoment, and communicates with the rest of the app.
  5. The functionality should largely remain the same as before, meaning the tests should pass, unless we find improvents.

Out of scope

No response

Additional Information

No response

Tasks

No response

@adamhaeger adamhaeger added the status/draft Status: When you create an issue before you have enough info to properly describe the issue. label Oct 22, 2024
@adamhaeger adamhaeger added quality/debt Epic and removed status/draft Status: When you create an issue before you have enough info to properly describe the issue. status/triage labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant