-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
additional trial by trial metrics - bias and plotting updates #29
Conversation
I computed duration (and other lick stats) for each epoch defined here: |
@hanhou @rachelstephlee @hagikent @ZhixiaoSu This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a comment on comments. I guess you are intentionally using df
and df_trials
?
@hagikent @hanhou @rachelstephlee @ZhixiaoSu pinging about a review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
sorry, just got to this now. i was testing this on a capsule. the figures are coming out all wonky to me in terms of dimensions. i've tried following your testing code. i think i'm missing something here.... capsule is here: (feel free to kick me out): https://codeocean.allenneuraldynamics.org/capsule/0613128/tree?cw=true i've sent you my ipynb file. can show you this during hackathon tomorrow also. |
src/aind_dynamic_foraging_basic_analysis/metrics/trial_metrics.py
Outdated
Show resolved
Hide resolved
Merging after resolving issues. Thanks everyone |
plot.plot_foraging_session
to include a wrapper function that takes NWBs, rather than passing in lists of choice and rewards. This is a quick fix for plot.plot_foraging_session does not operate on dataframes, but rather on lists of events. #10, but not a great solutionbias
toplot.plot_foraging_session
.plot.plot_foraging_session
, removes unnecessary whitespace.plot_foraging_session
, but more needed after metadata is cleaned up (finish migrating session stats to plot_foraging_session.py #34)