Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional trial by trial metrics - bias and plotting updates #29

Merged
merged 29 commits into from
Nov 21, 2024
Merged

Conversation

alexpiet
Copy link
Collaborator

@alexpiet alexpiet commented Nov 13, 2024

@alexpiet alexpiet changed the title additional metrics additional trial by trial metrics Nov 13, 2024
@hanhou
Copy link
Collaborator

hanhou commented Nov 16, 2024

  • trial duration (stop-time - start-time) (@hanhou in process_nwb.py was this trial_start to trial_stop time, or gocue to gocue?)

I computed duration (and other lick stats) for each epoch defined here:
https://github.com/AllenNeuralDynamics/aind-foraging-behavior-bonsai-basic/blob/5bd0db90bf9182a969bcb3c52af77c8bb9a36f19/code/process_nwbs.py#L87-L93

@alexpiet alexpiet changed the title additional trial by trial metrics additional trial by trial metrics - bias, ideal observer; and plotting updates Nov 18, 2024
@alexpiet alexpiet marked this pull request as ready for review November 18, 2024 21:44
@alexpiet
Copy link
Collaborator Author

@hanhou @rachelstephlee @hagikent @ZhixiaoSu This is ready for review.

@alexpiet
Copy link
Collaborator Author

alexpiet commented Nov 18, 2024

Example of adding bias to plot_foraging_session.py

example

Copy link

@hagikent hagikent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a comment on comments. I guess you are intentionally using df and df_trials?

@hagikent
Copy link

bias plot looks great.


can you make the ticks edge-aligned instead of centre-aligned?

e.g. for Right
Screenshot 2024-11-18 at 1 46 59 PM

Jeremiah wanted this change when we were working on posters/presentations and I thought it should be preemptively addressed here (instead of all of us get pushback individually).

@alexpiet
Copy link
Collaborator Author

@hagikent How does this look?
I also resolved #33 while I was at it
Screenshot 2024-11-18 at 3 27 32 PM

@alexpiet
Copy link
Collaborator Author

@hagikent @hanhou @rachelstephlee @ZhixiaoSu pinging about a review

Copy link

@hagikent hagikent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rachelstephlee
Copy link
Collaborator

sorry, just got to this now.

i was testing this on a capsule. the figures are coming out all wonky to me in terms of dimensions. i've tried following your testing code. i think i'm missing something here....

capsule is here: (feel free to kick me out): https://codeocean.allenneuraldynamics.org/capsule/0613128/tree?cw=true

i've sent you my ipynb file.

can show you this during hackathon tomorrow also.

@alexpiet alexpiet changed the title additional trial by trial metrics - bias, ideal observer; and plotting updates additional trial by trial metrics - bias and plotting updates Nov 21, 2024
@alexpiet
Copy link
Collaborator Author

Merging after resolving issues. Thanks everyone

@alexpiet alexpiet merged commit 379bd8b into main Nov 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants