Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updates pydantic and schema version #66

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Conversation

jtyoung84
Copy link
Contributor

Closes #65

  • Updates version of aind-data-schema and pydantic
  • Enforces users to input PosixPath strings when creating job requests
    • Since this service is expected to run on the HPC, it makes it easier to do this versus writing path translations
    • This also makes it so that the unit tests can run on Windows and Linux environments without issues, which should close out Support developer consistency across OS/ Windows #63

Copy link
Contributor

@helen-m-lin helen-m-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that unit tests all pass when run locally on a Windows machine. So, this PR should also close #63 as expected.

Copy link
Contributor

@mekhlakapoor mekhlakapoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out locally with Di's upload jobs example and I get an error response with no info about what went wrong. I get a more informative error when I use the template. I can send over the example csv on teams.

Screen Shot 2024-01-31 at 2 39 13 PM

@jtyoung84 jtyoung84 merged commit bf6c33a into main Feb 1, 2024
3 checks passed
@jtyoung84 jtyoung84 deleted the feat-65-schema-upgrade branch February 1, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update aind-data-schema version
3 participants