Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support developer consistency across OS/ Windows #63

Closed
helen-m-lin opened this issue Jan 26, 2024 · 2 comments
Closed

Support developer consistency across OS/ Windows #63

helen-m-lin opened this issue Jan 26, 2024 · 2 comments
Assignees

Comments

@helen-m-lin
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As a developer, I want to be able to run the unit tests and have the same experience on Windows compared to if I develop on Linux.

Describe the solution you'd like
Some issues with unit tests have already been resolved in previous PR #62 for path comparisons.

One remaining issue is that the error messages displayed from /api/validate_csv are slightly different depending on OS, which breaks the unit tests if running on Windows. We can pull out the error message text returned by /api/validate_csv using e.Exception or other format rather than directly returning repre(e), and update all unit tests affected.

Example:
Currently expected on Linux: "AttributeError('WRONG_MODALITY_HERE')"
Current expected on Windows: "AttributeError(\"type object 'Modality' has no attribute 'WRONG_MODALITY_HERE'\")"

We should check if there are any other issues related for running on different OS.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@jtyoung84
Copy link
Contributor

@jtyoung84 Create a user story for this

@jtyoung84
Copy link
Contributor

Closed by #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants