MIES_AnalysisFunctions_PatchSeq.ipf: Remove fallthrough to PRE_SET_EVENT #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 76b7cd2 (Patch Seq: Make it work with indexing, 2018-06-11) we introduced support for using indexing with the patch seq analysis functions. We did that by executing the code we can in PRE_SET_EVENT and everything else in PRE_DAQ_EVENT. The added fallthrough means that we execute the code in PRE_SET_EVENT also in PRE_DAQ_EVENT. It is not clear why we did it back then like that, so let's remove the fallthrough. We can then also remove the DAScale setting for PSQ_DAScale in the PRE_DAQ_EVENT. Close #1192
t-b
force-pushed
the
bugfix/1941-remove-fallthrough
branch
from
6faa7a1 to
0a27c2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 76b7cd2 (Patch Seq: Make it work with indexing, 2018-06-11) we introduced support for using indexing with the patch seq analysis functions. We did that by executing the code we can in PRE_SET_EVENT and everything else in PRE_DAQ_EVENT. The added fallthrough means that we execute the code in PRE_SET_EVENT also in PRE_DAQ_EVENT.
It is not clear why we did it back then like that, so let's remove the fallthrough.
Close #1192
The reason I'm doing that now is that I want to perform some more expensive tasks for DAScale adaptive supratreshold in PRE_SET_EVENT but then it matters if we execute that code in PRE_DAQ_EVENT or not.