Skip to content

Commit

Permalink
MIES_AnalysisFunctions_PatchSeq.ipf: Remove fallthrough to PRE_SET_EVENT
Browse files Browse the repository at this point in the history
In 76b7cd2 (Patch Seq: Make it work with indexing, 2018-06-11) we
introduced support for using indexing with the patch seq analysis
functions. We did that by executing the code we can in PRE_SET_EVENT and
everything else in PRE_DAQ_EVENT. The added fallthrough means that we
execute the code in PRE_SET_EVENT also in PRE_DAQ_EVENT.

It is not clear why we did it back then like that, so let's remove the
fallthrough.

Close #1192
  • Loading branch information
t-b committed Nov 15, 2023
1 parent de4e984 commit 6faa7a1
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions Packages/MIES/MIES_AnalysisFunctions_PatchSeq.ipf
Original file line number Diff line number Diff line change
Expand Up @@ -2165,8 +2165,7 @@ Function PSQ_DAScale(device, s)
endif

DisableControls(device, "Button_DataAcq_SkipBackwards;Button_DataAcq_SkipForward")

// fallthrough-by-design
break
case PRE_SET_EVENT:
SetAnalysisFunctionVersion(device, PSQ_DA_SCALE, s.headstage, s.sweepNo)

Expand Down Expand Up @@ -2585,8 +2584,7 @@ Function PSQ_SquarePulse(device, s)
endif

DisableControls(device, "Button_DataAcq_SkipBackwards;Button_DataAcq_SkipForward")

// fallthrough-by-design
break
case PRE_SET_EVENT:
SetAnalysisFunctionVersion(device, PSQ_SQUARE_PULSE, s.headstage, s.sweepNo)

Expand Down Expand Up @@ -2868,8 +2866,7 @@ Function PSQ_Rheobase(device, s)
endif

DisableControls(device, "Button_DataAcq_SkipBackwards;Button_DataAcq_SkipForward")

// fallthrough-by-design
break
case PRE_SET_EVENT:
SetAnalysisFunctionVersion(device, PSQ_RHEOBASE, s.headstage, s.sweepNo)

Expand Down Expand Up @@ -3324,8 +3321,7 @@ Function PSQ_Ramp(device, s)
endif

DisableControls(device, "Button_DataAcq_SkipBackwards;Button_DataAcq_SkipForward")

// fallthrough-by-design
break
case PRE_SET_EVENT:
SetAnalysisFunctionVersion(device, PSQ_RAMP, s.headstage, s.sweepNo)

Expand Down Expand Up @@ -4253,8 +4249,8 @@ Function PSQ_Chirp(device, s)
endif

DisableControls(device, "Button_DataAcq_SkipBackwards;Button_DataAcq_SkipForward")

case PRE_SET_EVENT: // fallthrough-by-design
break
case PRE_SET_EVENT:
SetAnalysisFunctionVersion(device, PSQ_CHIRP, s.headstage, s.sweepNo)

PSQ_SetAutobiasTargetVIfPresent(device, s.headstage, s.params, "AutobiasTargetV")
Expand Down

0 comments on commit 6faa7a1

Please sign in to comment.