Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update installer #667

Merged
merged 3 commits into from
Jan 19, 2017
Merged

Update installer #667

merged 3 commits into from
Jan 19, 2017

Conversation

mohierf
Copy link
Contributor

@mohierf mohierf commented Dec 30, 2016

@mohierf mohierf mentioned this pull request Dec 30, 2016
Closed
@mohierf mohierf changed the title Update installer [WiP] Update installer Dec 30, 2016
@mohierf
Copy link
Contributor Author

mohierf commented Dec 30, 2016 •
edited
Loading

@Seb-Solon : please have a look on the virtualenv test?

edit I fixed the virtualenv tests: broken because of removed / added files

@mohierf mohierf mentioned this pull request Jan 2, 2017
Merged
@mohierf mohierf changed the title [WiP] Update installer Update installer Jan 6, 2017
@mohierf mohierf mentioned this pull request Jan 11, 2017
Closed
@mohierf
Update alignak installation process
b78320a 
Update setup for packaging build
Remove pbr from the project dependencies (as of Alignak-monitoring/alignak-packaging#24)
Set alignak directories according to packaging choice
Update paths.cfg configuration file
Update dev launch script
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 82.884% when pulling 4fdbb0e on update-installer into 7d7f097 on develop.

ddurieux
ddurieux suggested changes Jan 19, 2017
View reviewed changes
etc/daemons/brokerd.ini
@@ -9,7 +9,7 @@ etcdir=/usr/local/etc/alignak

#-- Note that those variables:
# 1/ are used in this file as %(workdir)s
# 2/ are automatically updated during the Alignak installation process
# 2/ are automatically updated during the Alignak installation process (eg. python setup.py install)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace python setup.py install per pip install .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not necessary in this case it is the same

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

dev/restart_all.sh
@@ -1,6 +1,29 @@
#!/bin/sh
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you replace sh by bash, the unix standard is sh, not installed by default on Unix systems like FreeBSD

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but as far as I remember, some features in those scripts are bash specific. If it is necessary to support the restricted sh we will log an issue

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I will log an issue

requirements.txt
@@ -4,9 +4,9 @@
CherryPy
requests>=2.7.0
importlib
pbr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove pbr you should remove ref too in setup.py and setup.cfg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not yet removed in setup.py .. because some features in setup.py still require pbr but it is not anymore in the requirements that are used by the packaging.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok I see

@ddurieux ddurieux merged commit 07f2318 into develop Jan 19, 2017
@ddurieux ddurieux deleted the update-installer branch January 19, 2017 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddurieux ddurieux ddurieux requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohierf @coveralls @ddurieux