Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Included trigger in template generator + trigger example #1876

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Included trigger in template generator + trigger example #1876

wants to merge 2 commits into from

Conversation

jackal1-66
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@jackal1-66 jackal1-66 mentioned this pull request Jan 16, 2025
Closed
@jackal1-66
Copy link
Collaborator Author

jackal1-66 commented Jan 16, 2025 •
edited
Loading

PR linked to AliceO2Group/AliceO2#13873

@jackal1-66 jackal1-66 mentioned this pull request Jan 17, 2025
Merged
@jackal1-66 jackal1-66 changed the title Included trigger in template generator Included trigger in template generator + trigger example Jan 17, 2025
sawenzel
sawenzel reviewed Jan 23, 2025
View reviewed changes
MC/bin/o2_hybrid_gen.py Outdated
# Available options for trigger are "off", "or", "and"
# in all the other cases the trigger is forced "off"

trgbase = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could print this only when the user asks for it. Otherwise it might bloat the JSON quickly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add a --trigger flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sawenzel sawenzel sawenzel left review comments

@chiarazampolli chiarazampolli Awaiting requested review from chiarazampolli chiarazampolli is a code owner

@benedikt-voelkel benedikt-voelkel Awaiting requested review from benedikt-voelkel benedikt-voelkel is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackal1-66 @sawenzel