Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger implementation in hybrid generator #13873

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

jackal1-66
Copy link
Collaborator

No description provided.

@jackal1-66 jackal1-66 requested a review from sawenzel as a code owner January 17, 2025 15:00
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

Please consider the following formatting changes to AliceO2Group#13873
@jackal1-66
Copy link
Collaborator Author

PR linked to AliceO2Group/O2DPG#1876

@jackal1-66 jackal1-66 requested a review from a team as a code owner January 17, 2025 16:43
jackal1-66 added a commit to jackal1-66/AliceO2 that referenced this pull request Jan 17, 2025
Please consider the following formatting changes to AliceO2Group#13873
@jackal1-66 jackal1-66 force-pushed the advancedTrigger branch 2 times, most recently from 95f7c47 to 6b7c06f Compare January 17, 2025 16:47
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for b717bbf at 2025-01-17 18:53:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile digi.log
digi.log:[24780:internal-dpl-ccdb-backend]: [17:53:25][ERROR] Exception while running: Fa
[24780:internal-dpl-ccdb-backend]: [17:53:23][ERROR] CCDBDownloader CURL transfer error - Timeout was reached
[24780:internal-dpl-ccdb-backend]: [17:53:23][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/CTP/Calib/OrbitReset for 1550600800000 (agent_id: alimetal02.cern.ch-1737136396-Z2mm1G) with http code: 0
[24780:internal-dpl-ccdb-backend]: [17:53:23][ERROR] File CTP/Calib/OrbitReset could not be retrieved. No more hosts to try.
[24780:internal-dpl-ccdb-backend]: [17:53:23][FATAL] Unable to find object CTP/Calib/OrbitReset/1550600800000
[24780:internal-dpl-ccdb-backend]: [17:53:25][ERROR] Exception while running: Fatal error. Rethrowing.
[24780:internal-dpl-ccdb-backend]: [17:53:25][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-sim-digitizer-workflow, device shutting down. Reason: Fatal error
[ERROR] Workflow crashed - PID 24780 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/ff38300b23f25fc4bb868157c46f12d599787d21/slc8_x86-64/o2checkcode/1.0-local37/etc/modulefiles
++ cat
--

Full log here.

@sawenzel
Copy link
Collaborator

Thanks! There are some real compiler errors in the MacOS build. Once fixed, this can be merged.

@jackal1-66
Copy link
Collaborator Author

Thanks! There are some real compiler errors in the MacOS build. Once fixed, this can be merged.

I wrapped the logical errors and pushed the fix. Let's wait for the CI

@alibuild
Copy link
Collaborator

alibuild commented Jan 20, 2025

Error while checking build/O2/fullCI_slc9 for d387901 at 2025-01-22 17:44:

## sw/BUILD/ONNXRuntime-latest/log
CMake Error at /sw/slc9_x86-64/CMake/v3.28.1-13/share/cmake-3.28/Modules/CMakeFindDependencyMacro.cmake:76 (find_package):

Full log here.

@jackal1-66
Copy link
Collaborator Author

Error while checking build/O2/fullCI_slc9 for d387901 at 2025-01-20 21:56:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile digi.log
digi.log:[15808:internal-dpl-ccdb-backend]: [21:56:50][ERROR] Exception while running: Fatal error. Rethrowing.
digi.log-[15808:internal-dpl-ccdb-backend]: [21:56:50][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-sim-digitizer-workflow, device shutting down. Reason: Fatal error
[15808:internal-dpl-ccdb-backend]: [21:56:48][ERROR] CCDBDownloader CURL transfer error - Timeout was reached
[15808:internal-dpl-ccdb-backend]: [21:56:48][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/CTP/Calib/OrbitReset for 1550600800000 (agent_id: alimetal01.cern.ch-1737406601-cH58LL) with http code: 0
[15808:internal-dpl-ccdb-backend]: [21:56:48][ERROR] File CTP/Calib/OrbitReset could not be retrieved. No more hosts to try.
[15808:internal-dpl-ccdb-backend]: [21:56:48][FATAL] Unable to find object CTP/Calib/OrbitReset/1550600800000
[15808:internal-dpl-ccdb-backend]: [21:56:50][ERROR] Exception while running: Fatal error. Rethrowing.
[15808:internal-dpl-ccdb-backend]: [21:56:50][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-sim-digitizer-workflow, device shutting down. Reason: Fatal error
[ERROR] Workflow crashed - PID 15808 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/282289254d040411ee834bde25b385871c756322/slc9_x86-64/o2checkcode/1.0-local88/etc/modulefiles
++ cat
--

Full log here.

seems unrelated to this PR and further test succeeded

@jackal1-66
Copy link
Collaborator Author

build/O2/fullCI_slc9 error is unrelated to this PR. @singiamtel can you confirm?

@jackal1-66
Copy link
Collaborator Author

jackal1-66 commented Jan 23, 2025

All tests are now successful, PR can be merged (together with its linked O2DPG one)

@sawenzel sawenzel merged commit 611600b into AliceO2Group:dev Jan 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants