[AnalysisQC] Change configuration logic #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benedikt-voelkel
requested review from
sawenzel and
chiarazampolli
as code owners
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
benedikt-voelkel
force-pushed
the
analysis-qc
branch
from
06af497 to
3d9abaf
Compare
|
@chiarazampolli @noferini @catalinristea At this point, there is no difference in configurations for pp and PbPb, it's all the same.
Note that the merged analyses pipe takes around 1.5 times as long as running all single analyses in parallel. |
* remove unused analyses
* disable EMCAL analysis
(to enable, need to revise resource needs, crashes or hangs
sporadically)
* split config JSONs into executable-specific single JSONs
Most of those are seen as configurations for "service wagons".
Each analyses is forced to use those comon configurations and it is
not possible to have analysis-specific configurations for service
wagons.
* possible to use special configuration strings in configs; this is done
to avoid duplications of configs
* "!ANALYSIS_QC_is_mc!" ("!ANALYSIS_QC_is_data!") will be replaced
with "true"("false") or "false"("true") depending on whether the
analyses are run on MC(data)
* new default is to pipe all analyses together;
to split into single analyses, run
o2dpg_analysis_testing_workflow.py [...] --split-analyses
benedikt-voelkel
force-pushed
the
analysis-qc
branch
from
3d9abaf to
0f4bda3
Compare
This was referenced Apr 12, 2024
benedikt-voelkel
added
async-2022-pp-apass4
async-2023-pbpb-apass4
benedikt-voelkel
added a commit
that referenced
this pull request
Apr 26, 2024
* remove unused analyses
* disable EMCAL analysis
(to enable, need to revise resource needs, crashes or hangs
sporadically)
* split config JSONs into executable-specific single JSONs
Most of those are seen as configurations for "service wagons".
Each analyses is forced to use those comon configurations and it is
not possible to have analysis-specific configurations for service
wagons.
* possible to use special configuration strings in configs; this is done
to avoid duplications of configs
* "!ANALYSIS_QC_is_mc!" ("!ANALYSIS_QC_is_data!") will be replaced
with "true"("false") or "false"("true") depending on whether the
analyses are run on MC(data)
* new default is to pipe all analyses together;
to split into single analyses, run
o2dpg_analysis_testing_workflow.py [...] --split-analyses
Co-authored-by: Benedikt Volkel <[email protected]>
benedikt-voelkel
added a commit
that referenced
this pull request
Apr 26, 2024
* remove unused analyses
* disable EMCAL analysis
(to enable, need to revise resource needs, crashes or hangs
sporadically)
* split config JSONs into executable-specific single JSONs
Most of those are seen as configurations for "service wagons".
Each analyses is forced to use those comon configurations and it is
not possible to have analysis-specific configurations for service
wagons.
* possible to use special configuration strings in configs; this is done
to avoid duplications of configs
* "!ANALYSIS_QC_is_mc!" ("!ANALYSIS_QC_is_data!") will be replaced
with "true"("false") or "false"("true") depending on whether the
analyses are run on MC(data)
* new default is to pipe all analyses together;
to split into single analyses, run
o2dpg_analysis_testing_workflow.py [...] --split-analyses
Co-authored-by: Benedikt Volkel <[email protected]>
benedikt-voelkel
removed
the
async-2023-pbpb-apass4
benedikt-voelkel
added a commit
to benedikt-voelkel/O2DPG
that referenced
this pull request
May 14, 2024
* remove unused analyses
* disable EMCAL analysis
(to enable, need to revise resource needs, crashes or hangs
sporadically)
* split config JSONs into executable-specific single JSONs
Most of those are seen as configurations for "service wagons".
Each analyses is forced to use those comon configurations and it is
not possible to have analysis-specific configurations for service
wagons.
* possible to use special configuration strings in configs; this is done
to avoid duplications of configs
* "!ANALYSIS_QC_is_mc!" ("!ANALYSIS_QC_is_data!") will be replaced
with "true"("false") or "false"("true") depending on whether the
analyses are run on MC(data)
* new default is to pipe all analyses together;
to split into single analyses, run
o2dpg_analysis_testing_workflow.py [...] --split-analyses
Co-authored-by: Benedikt Volkel <[email protected]>
benedikt-voelkel
added a commit
that referenced
this pull request
May 14, 2024
* remove unused analyses
* disable EMCAL analysis
(to enable, need to revise resource needs, crashes or hangs
sporadically)
* split config JSONs into executable-specific single JSONs
Most of those are seen as configurations for "service wagons".
Each analyses is forced to use those comon configurations and it is
not possible to have analysis-specific configurations for service
wagons.
* possible to use special configuration strings in configs; this is done
to avoid duplications of configs
* "!ANALYSIS_QC_is_mc!" ("!ANALYSIS_QC_is_data!") will be replaced
with "true"("false") or "false"("true") depending on whether the
analyses are run on MC(data)
* new default is to pipe all analyses together;
to split into single analyses, run
o2dpg_analysis_testing_workflow.py [...] --split-analyses
Co-authored-by: Benedikt Volkel <[email protected]>
(cherry picked from commit 1df34c0)
benedikt-voelkel
added a commit
that referenced
this pull request
May 16, 2024
* remove unused analyses
* disable EMCAL analysis
(to enable, need to revise resource needs, crashes or hangs
sporadically)
* split config JSONs into executable-specific single JSONs
Most of those are seen as configurations for "service wagons".
Each analyses is forced to use those comon configurations and it is
not possible to have analysis-specific configurations for service
wagons.
* possible to use special configuration strings in configs; this is done
to avoid duplications of configs
* "!ANALYSIS_QC_is_mc!" ("!ANALYSIS_QC_is_data!") will be replaced
with "true"("false") or "false"("true") depending on whether the
analyses are run on MC(data)
* new default is to pipe all analyses together;
to split into single analyses, run
o2dpg_analysis_testing_workflow.py [...] --split-analyses
Co-authored-by: Benedikt Volkel <[email protected]>
(cherry picked from commit 1df34c0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disable EMCAL analysis
(to enable, need to revise resource needs, crashes or hangs
sporadically)
split config JSONs into executable-specific single JSONs Most of those are seen as configurations for "service wagons". Each analyses is forced to use those comon configurations and it is not possible to have analysis-specific configurations for service wagons.
possible to use special configuration strings in configs; this is done to avoid duplications of configs
new default is to pipe all analyses together; to split into single analyses, run o2dpg_analysis_testing_workflow.py [...] --split-analyses