Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1010] Hide protobuf dependency from the c++ library #1530

Merged

Conversation

martinboulais
Copy link
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for developers:

  • Breaking changes in c++ library:
    • Removed proto bookkeeping API
    • Moved DPL process registration to non-proto API
    • Remove Get runs functions

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.66%. Comparing base (8dbfbfa) to head (6e6bcee).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1530   +/-   ##
=======================================
  Coverage   43.66%   43.66%           
=======================================
  Files         844      844           
  Lines       14275    14275           
  Branches     2555     2555           
=======================================
  Hits         6233     6233           
  Misses       8042     8042           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinboulais martinboulais force-pushed the mboulais/O2B-1010/hide-library-protobuf-dependency branch from e49adaa to 0b2cda8 Compare May 3, 2024 07:09
Copy link
Contributor

@Barthelemy Barthelemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on my machine, it works

@martinboulais martinboulais merged commit 9177e96 into main May 23, 2024
8 checks passed
@martinboulais martinboulais deleted the mboulais/O2B-1010/hide-library-protobuf-dependency branch May 23, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants