Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O2B-1010] Hide protobuf internals #2255

Merged
merged 2 commits into from
May 8, 2024
Merged

[O2B-1010] Hide protobuf internals #2255

merged 2 commits into from
May 8, 2024

Conversation

martinboulais
Copy link
Contributor

Adapt to bookkeeping library hiding the internal dependency on protobuf
Depends on AliceO2Group/Bookkeeping#1530

Barthelemy
Barthelemy approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@Barthelemy Barthelemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve but this will be merged only when the new BK has been released and updated in alidist

@Barthelemy Barthelemy enabled auto-merge (squash) April 30, 2024 11:49
@Barthelemy Barthelemy merged commit 49f3dce into AliceO2Group:master May 8, 2024
6 of 7 checks passed
@martinboulais martinboulais deleted the mboulais/O2B-1010/hide-protobuf-internals branch May 8, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Barthelemy Barthelemy Barthelemy approved these changes

@knopers8 knopers8 Awaiting requested review from knopers8 knopers8 is a code owner

@justonedev1 justonedev1 Awaiting requested review from justonedev1 justonedev1 is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinboulais @Barthelemy