Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spurious detectors from Runs views #1506

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Apr 11, 2024

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Removed spurious detectors from Runs Per Data Pass and Runs Per Simulation Pass pages

Notable changes for developers:

  • NA

Changes made to the database:

  • NA

@xsalonx xsalonx added bug Something isn't working frontend labels Apr 11, 2024
@xsalonx xsalonx self-assigned this Apr 11, 2024
@xsalonx xsalonx marked this pull request as ready for review April 11, 2024 14:32
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 44.29%. Comparing base (c3a895a) to head (57f165a).

Files Patch % Lines
.../ActiveColumns/runDetectorsAsyncQcActiveColumns.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
- Coverage   44.30%   44.29%   -0.01%     
==========================================
  Files         802      802              
  Lines       13413    13416       +3     
  Branches     2391     2392       +1     
==========================================
  Hits         5942     5942              
- Misses       7471     7474       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xsalonx xsalonx merged commit 5d0650e into main Apr 12, 2024
6 of 8 checks passed
@xsalonx xsalonx deleted the xsalonx/bugfix/QCF/not-all-detectors branch April 12, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Development

Successfully merging this pull request may close these issues.

2 participants