Remove spurious detectors from Runs views (#1506)

* emove spurious detectors * fix test
AliceO2Group · Apr 12, 2024 · 5d0650e · 5d0650e
1 parent c3a895a
commit 5d0650e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/lib/public/views/Runs/ActiveColumns/runDetectorsAsyncQcActiveColumns.js b/lib/public/views/Runs/ActiveColumns/runDetectorsAsyncQcActiveColumns.js
@@ -31,6 +31,11 @@ export const createRunDetectorsAsyncQcActiveColumns = (dplDetectors, { profiles,
                 if (dataPassId && simulationPassId) {
                     throw new Error('`dataPassId` are `simulationPassId` are exclusive options');
                 }
+
+                const detectorWasActiveDuringRun = Boolean(run.detectorsQualities.find(({ name }) => name === detectorName));
+                if (!detectorWasActiveDuringRun) {
+                    return null;
+                }
                 const detectorQualityDisplay = h('.btn.white.bg-primary', 'QC');
 
                 if (dataPassId) {

diff --git a/test/public/runs/runsPerDataPass.overview.test.js b/test/public/runs/runsPerDataPass.overview.test.js
@@ -96,7 +96,7 @@ module.exports = () => {
             timeTrgEnd: (date) => !isNaN(Date.parse(date)),
             aliceL3Current: (current) => !isNaN(Number(current)),
             aliceL3Dipole: (current) => !isNaN(Number(current)),
-            ...Object.fromEntries(DETECTORS.map((detectorName) => [detectorName, (quality) => expect(quality).to.be.equal('QC')])),
+            ...Object.fromEntries(DETECTORS.map((detectorName) => [detectorName, (quality) => expect(quality).to.be.oneOf(['QC', ''])])),
         };
 
         // We find the headers matching the datatype keys

diff --git a/test/public/runs/runsPerSimulationPass.overview.test.js b/test/public/runs/runsPerSimulationPass.overview.test.js
@@ -97,7 +97,7 @@ module.exports = () => {
 
             aliceL3Current: (current) => !isNaN(Number(current.replace(/,/g, ''))),
             dipoleCurrent: (current) => !isNaN(Number(current.replace(/,/g, ''))),
-            ...Object.fromEntries(DETECTORS.map((detectorName) => [detectorName, (quality) => expect(quality).to.be.equal('QC')])),
+            ...Object.fromEntries(DETECTORS.map((detectorName) => [detectorName, (quality) => expect(quality).to.be.oneOf(['QC', ''])])),
         };
 
         await validateTableData(page, new Map(Object.entries(tableDataValidators)));