[O2B-1162] Display all PHYSICS runs on Data Pass view

lib/public/components/common/navigation/breadcrumbs.js

@@ -0,0 +1,25 @@
+/**
+ * @license
+ * Copyright 2019-2020 CERN and copyright holders of ALICE O2.
+ * See http://alice-o2.web.cern.ch/copyright for details of the copyright holders.
+ * All rights not expressly granted are reserved.
+ *
+ * This software is distributed under the terms of the GNU General Public
+ * License v3 (GPL Version 3), copied verbatim in the file "COPYING".
+ *
+ * In applying this license CERN does not waive the privileges and immunities
+ * granted to it by virtue of its status as an Intergovernmental Organization
+ * or submit itself to any jurisdiction.
+ */
+
+import { h, iconChevronRight } from '/js/src/index.js';
+
+/**
+ * Create Breadcrumbs out of provided items which are separated with rightChevron Icon
+ * @param {Component[]} items items in breadcrumbs
+ * @return {Component} breadcrumbs
+ */
+export const breadcrumbs = (...items) => h('.flex-row.g1.items-center', [
+    items[0],
+    ...items.slice(1).flatMap((item) => [iconChevronRight(), item]),
+]);

lib/public/views/Runs/RunPerDataPass/RunsPerDataPassOverviewModel.js

@@ -83,7 +83,6 @@ export class RunsPerDataPassOverviewModel extends RunsOverviewModel {
         const endpint = super.getRootEndpoint();
         return buildUrl(endpint, { filter: {
             dataPassIds: [this._dataPassId],
-            runQualities: 'good',
             definitions: 'PHYSICS',
         } });
     }

lib/public/views/Runs/RunPerDataPass/RunsPerDataPassOverviewPage.js

@@ -11,14 +11,17 @@
  * or submit itself to any jurisdiction.
  */
 
-import { h } from '/js/src/index.js';
+import { h, iconWarning } from '/js/src/index.js';
 import { table } from '../../../components/common/table/table.js';
 import { createRunDetectorsActiveColumns } from '../ActiveColumns/runDetectorsActiveColumns.js';
 import { paginationComponent } from '../../../components/Pagination/paginationComponent.js';
 import { estimateDisplayableRowsCount } from '../../../utilities/estimateDisplayableRowsCount.js';
 import { exportRunsTriggerAndModal } from '../Overview/exportRunsTriggerAndModal.js';
 import { runsActiveColumns } from '../ActiveColumns/runsActiveColumns.js';
 import spinner from '../../../components/common/spinner.js';
+import { tooltip } from '../../../components/common/popover/tooltip.js';
+import errorAlert from '../../../components/common/errorAlert.js';
+import { breadcrumbs } from '../../../components/common/navigation/breadcrumbs.js';
 
 const TABLEROW_HEIGHT = 59;
 // Estimate of the navbar and pagination elements height total; Needs to be updated in case of changes;
@@ -46,14 +49,19 @@ export const RunsPerDataPassOverviewPage = ({ runs: { perDataPassOverviewModel }
         }), { profiles: 'runsPerDataPass' }),
     };
 
+    const commonTitle = h('h2', { style: 'white-space: nowrap;' }, 'Physics Runs');
+
     return h('', [
-        h('.flex-row.justify-between.items-center', [
-            dataPass.match({
-                Success: (payload) => h('h2', `Good, physics runs of ${payload.name}`),
-                Failure: () => h('h2.danger', 'Failed to fetch Data Pass information'),
-                Loading: () => h('.p1', spinner({ size: 2, absolute: false })),
-                NotAsked: () => h('h2', 'Good, physics runs'),
-            }),
+        h('.flex-row.justify-between.items-center.g2', [
+            h(
+                '.flex-row.g1.items-center',
+                dataPass.match({
+                    Success: (payload) => breadcrumbs(commonTitle, h('h2', payload.name)),
+                    Failure: (payload) => [commonTitle, tooltip(h('.f3', iconWarning()), errorAlert(payload))],
+                    Loading: () => [commonTitle, spinner({ size: 2, absolute: false })],
+                    NotAsked: () => [commonTitle, tooltip(h('.f3', iconWarning()), errorAlert([{ detail: 'No data was asked for' }]))],
+                }),
+            ),
             exportRunsTriggerAndModal(perDataPassOverviewModel, modalModel),
         ]),
         h('.flex-column.w-100', [

test/public/runs/runsPerDataPass.overview.test.js

@@ -79,8 +79,8 @@ module.exports = () => {
         expect(title).to.equal('AliceO2 Bookkeeping');
 
         await page.waitForSelector('h2');
-        const viewTitle = await page.$eval('h2', (element) => element.innerText);
-        expect(viewTitle).to.be.eql('Good, physics runs of LHC22a_apass1');
+        const viewTitleElements = await Promise.all((await page.$$('h2')).map((element) => element.evaluate(({ innerText }) => innerText)));
+        expect(viewTitleElements).to.have.all.ordered.members(['Physics Runs', 'LHC22a_apass1']);
     });
 
     it('shows correct datatypes in respective columns', async () => {