Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1162] Display all PHYSICS runs on Data Pass view #1413

Merged
merged 22 commits into from
Mar 1, 2024

Conversation

xsalonx
Copy link
Collaborator

@xsalonx xsalonx commented Feb 16, 2024

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • All PHYSICS runs are displayed on Runs Per Data Pass view, regardless of their online quality

Notable changes for developers:

  • Use breadcrumbs for Runs Per Data Pass page title and tooltip to display error

Changes made to the database:

  • NA

@xsalonx xsalonx self-assigned this Feb 16, 2024
@xsalonx
Copy link
Collaborator Author

xsalonx commented Feb 16, 2024

To be merged after #1412

@xsalonx xsalonx changed the title Xsalonx/mc/o2 b 1162/update display rules [O2B-1162] Update display rules on Runs Per Data Pass view Feb 16, 2024
@xsalonx xsalonx changed the title [O2B-1162] Update display rules on Runs Per Data Pass view [O2B-1162] Display all PHYSICS runs on Data Pass view Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.81%. Comparing base (24ddf8b) to head (a922511).
Report is 331 commits behind head on main.

❗ Current head a922511 differs from pull request most recent head df31478. Consider uploading reports for the commit df31478 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1413      +/-   ##
==========================================
- Coverage   48.78%   44.81%   -3.98%     
==========================================
  Files         528      743     +215     
  Lines        7968    12019    +4051     
  Branches     1477     2169     +692     
==========================================
+ Hits         3887     5386    +1499     
- Misses       4081     6633    +2552     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xsalonx xsalonx marked this pull request as ready for review February 27, 2024 10:04
@xsalonx xsalonx requested a review from martinboulais March 1, 2024 08:20
@xsalonx xsalonx merged commit e222334 into main Mar 1, 2024
4 checks passed
@xsalonx xsalonx deleted the xsalonx/MC/O2B-1162/update-display-rules branch March 1, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants