-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(fast-usdc): prune testBorrow, testRepay methods #10607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rationale makes sense to me
@@ -494,3 +494,29 @@ test('repay fails when seat allocation does not equal amounts', t => { | |||
}, | |||
); | |||
}); | |||
|
|||
test('repay succeeds with no Pool or Contract Fee', t => { | |||
const { USDC } = brands; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of scope: consider using withAmountUtils
to make the brands, issuers and amounts easier to work with
totalBorrows: make(USDC, 100n), | ||
}; | ||
const fromSeatAllocation = amounts; | ||
t.notThrows(() => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider verifying the shareWorth
doesn't change and encumberedBalance
does.
Deploying agoric-sdk with Cloudflare Pages
|
fbfe008
to
a6b86da
Compare
ffc0cbc
to
78c2eab
Compare
- largely covered by share-pool-math tests - move 'repay succeeds with no Pool or Contract Fee' from contract test to pool-share-math test. - borrow / repay are internal APIs with static types - testing consistency between interface guards and static types might have some value, but not enough
78c2eab
to
d96a45e
Compare
closes: #10388
refs: #10511
Description
Prune
testBorrow
,testRepay
methods along with contract tests that depend on them.lp.borrower.borrow
/lp.repayer.repay
.These are internal APIs with static types.
might have some value, but, I suggest, not enough for the cost
Scaling / Documentation / Upgrade Considerations
none
Security / Testing Considerations
small loss in test coverage - mostly in test redundancy
makeTestPushInvitation
remains on the public facet. Getting rid of it in due course remains critical.I expect / hope we can get rid of it in #10606 (cc @samsiegart ) .
Ideally, the liquidity-pool exo would have unit test coverage. I looked into that but found that I would have to build substantial ZCF / Zoe test tooling. Since
liquidity-pool.js
is just 360 lines of straightforward Zoe API usage, I suggest we postpone that under...