Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract flow tests #10388

Closed
1 of 2 tasks
turadg opened this issue Nov 1, 2024 · 1 comment · Fixed by #10607
Closed
1 of 2 tasks

Contract flow tests #10388

turadg opened this issue Nov 1, 2024 · 1 comment · Fixed by #10607
Assignees
@dckc
Labels
enhancement New feature or request
Milestone
FU1: package inte...

Comments

@turadg
Copy link
Member

turadg commented Nov 1, 2024 •
edited by dckc
Loading

What is the Problem Being Solved?

The FUC contract needs a test of its flows and error handling.

This issue is short of integrating with SwingSet, vstorage or other chains.

Description of the Design / Test Plan

Package test exercising

Security Considerations

Scaling Considerations

Upgrade Considerations
@turadg turadg added the enhancement New feature or request label Nov 1, 2024
@turadg turadg added this to the FU1: package integration milestone Nov 1, 2024
This was referenced Nov 1, 2024
Closed
Closed
Closed
This was referenced Nov 26, 2024
Merged
Closed
mergify bot added a commit that referenced this issue Nov 27, 2024
@mergify
test: fast-usdc contract flow (#10572)
45d0417 
refs: #10388
closes: #10577

doesn't close until
 - exercise all the code in the contract (analytic; best effort)

## Description / Testing Considerations

 - [x] test all the sequences in the product spec
    - [x] enumerate all the sequences in the product spec
 - [x] fix advancer/settler amount agreement bug

postponed:
 - 
 - #10510
    - [todo] C12 - Contract MUST only pay back the Pool only if they started the advance before USDC is minted
 - #10554

some `test.todo()`s are out of scope of contract flow tests. Some are more feasible as exo tests:
  - [todo] C18 - forward - MUST log and alert these incidents
  - [skip] LP borrow - TODO: move to exo test
  - [skip] LP repay - TODO: move to exo test

an some are after M1:
  - [todo] PERF: Target: settlement completes in a few minutes (after USDC is minted)
  - [todo] fee levels MUST be visible to external parties - i.e., written to public storage
  - [todo] C21 - Contract MUST log / timestamp each step in the transaction flow

### Security / Scaling / Upgrade Considerations

n/a

### Documentation Considerations

Internal design docs are assumed background knowledge.
@LuqiPan
Copy link
Contributor

LuqiPan commented Dec 2, 2024

@dckc is gonna remove skipped tests by either removing them or make them pass

@dckc dckc mentioned this issue Dec 3, 2024
Merged
@mergify mergify bot closed this as completed in #10607 Dec 3, 2024
@mergify mergify bot closed this as completed in 11c895a Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dckc dckc

Labels
enhancement New feature or request
Projects
None yet
Milestone
FU1: package integration
Development

Successfully merging a pull request may close this issue.

chore(fast-usdc): prune testBorrow, testRepay methods Agoric/agoric-sdk
3 participants
@turadg @dckc @LuqiPan