feat: local-orch-account .transfer() supports pfm routes
#10571
+1,920
−474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
81d1df5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2ebaf7c9.agoric-sdk.pages.dev |
| Branch Preview URL: | https://pc-10445-transfer-pfm.agoric-sdk.pages.dev |
0xpatrickdev
force-pushed
the
10006-transfer-pfm
branch
from
d6db026
to
2fa2f75
Compare
0xpatrickdev
force-pushed
the
pc/10445-transfer-pfm
branch
from
c111b13
to
05dd05c
Compare
|
Base branch is changed to master. Please re-run the integration tests by adding 'force:integration' label. |
0xpatrickdev
commented
Nov 26, 2024
0xpatrickdev
commented
Nov 26, 2024
0xpatrickdev
force-pushed
the
pc/10445-transfer-pfm
branch
from
05dd05c
to
310a176
Compare
- shape used for pfm ForwardInfo options
- provide `chainInfo` and `assetInfo` in commonPrivateArgs for contracts to use - register common assets used in testing - provide `populateChainHub` function for use in exo unit testing in favor of `registerAgoricBld`
0xpatrickdev
force-pushed
the
pc/10445-transfer-pfm
branch
from
310a176
to
5977597
Compare
this test can no longer rely on the IST brand being available, so we - added checks to ensure brands are accepted for `.transfer` and `.send` - filed #10449 since this surfaced a bug in `amountToCoin` - use Moolah issuer for "no denom for brand" failure path tests
- enables sending offers with brands
- chainInfo and assetInfo are provided as `commonPrivateArgs`. include them in `ContractMeta`
- auto-stake-it initializes `chainHub` with data so existing tests that use `.transfer()` pass
- no longer needed since we call `registerChainsAndAssets`
- no longer relies on buggy agoricNames - continues to test async-flow resumability and cross-chain vow settlement across upgrade Co-authored-by: 0xPatrick <[email protected]>
- test/bootstrapTests/orchestration.test.ts used a mixed of test and test.serial - the test without `.serial` interleaved and was confusing to debug - this mainly updates inline snapshots, which return different account and channel identifiers since all tests in this file share the same context
- basic-flows.contract.js is provided with chainInfo and assetInfo in privateArgs via builder options - needed for tests that use localAccount.transfer(), now reliant on asset info, to pass
0xpatrickdev
force-pushed
the
pc/10445-transfer-pfm
branch
from
5977597
to
9c0a243
Compare
0xpatrickdev
force-pushed
the
pc/10445-transfer-pfm
branch
from
af67a1f
to
e6de422
Compare
0xpatrickdev
commented
Nov 28, 2024
0xpatrickdev
requested review from
AgoricTriage,
turadg,
dckc and
samsiegart
- support both `yarn test:main` and `yarn test:fast-usdc` which have different chainInfo
0xpatrickdev
force-pushed
the
pc/10445-transfer-pfm
branch
from
e6de422
to
81d1df5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10445
Description
ChainHub.makeTransferRouteto support PFM routing inLocalOrchAccount.transfer()chainHubin exo and contract testscontract-upgrade.test.tsto no longer rely on a buggyagoricNameschainHubto facilitate boot and multichain testingSecurity Considerations
No new considerations from these changes.
Scaling Considerations
No new considerations from these changes.
Documentation Considerations
None
Testing Considerations
Includes unit tests. See #10584 for more robust testing of the pfm route logic. Existing
multichain-testingwill cover potential regressions (single-hop) transfers. Multi-hop tests are forthcoming.Upgrade Considerations
N/A, library code. Part of NPM Orch or FUSDC release.